diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2019-05-06 11:40:17 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2020-02-15 15:36:56 +0000 |
| commit | b5c883f298ebd7d459e8247531e6ca3b6dda45cd (patch) | |
| tree | 1fc8a16a24d0d08f189e9fb7133ad2d374cfcac6 /src/target/nds32.h | |
| parent | 9cf7dff97481fc8f698cdedb821be0fde7d6c80a (diff) | |
| download | riscv-openocd-b5c883f298ebd7d459e8247531e6ca3b6dda45cd.zip riscv-openocd-b5c883f298ebd7d459e8247531e6ca3b6dda45cd.tar.gz riscv-openocd-b5c883f298ebd7d459e8247531e6ca3b6dda45cd.tar.bz2 | |
target/nds32: fix type of magic number
The macro NDS32_COMMON_MAGIC was cast-ed to int to avoid compile
time error for comparison type mismatch while comparing it with
the field common_magic.
This is incorrect because the macro value is a 32 bit unsigned
value; better changing the type of the field common_magic to keep
the unsigned value.
Issue identified by checkpatch script from Linux kernel v5.1 using
the command
find src/ -type f -exec ./tools/scripts/checkpatch.pl \
-q --types TYPECAST_INT_CONSTANT -f {} \;
Change-Id: Ib5924b6cecdffe70ab5c78d3b30a9c8e4deb7c7b
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5193
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/target/nds32.h')
| -rw-r--r-- | src/target/nds32.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/target/nds32.h b/src/target/nds32.h index 141dbf4..3670fd2 100644 --- a/src/target/nds32.h +++ b/src/target/nds32.h @@ -82,7 +82,7 @@ enum nds32_syscall_id { NDS32_SYSCALL_ERRNO = 6001, }; -#define NDS32_COMMON_MAGIC (int)0xADE5ADE5 +#define NDS32_COMMON_MAGIC 0xADE5ADE5U struct nds32_edm { @@ -235,7 +235,7 @@ struct nds32_misc_config { * Represents a generic Andes core. */ struct nds32 { - int common_magic; + uint32_t common_magic; struct reg_cache *core_cache; /** Handle for the debug module. */ |