diff options
| author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2013-11-07 00:40:50 +0100 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2014-01-20 13:28:26 +0000 |
| commit | 63fa73169bd88258ef82f709e79769eacc50f793 (patch) | |
| tree | 5f259281041de2aa5d7097db46a64d4175279a96 /src/target/arm7tdmi.c | |
| parent | 87e91f4db9bea66a7866261130c6152c0304bc29 (diff) | |
| download | riscv-openocd-63fa73169bd88258ef82f709e79769eacc50f793.zip riscv-openocd-63fa73169bd88258ef82f709e79769eacc50f793.tar.gz riscv-openocd-63fa73169bd88258ef82f709e79769eacc50f793.tar.bz2 | |
Retire jtag_add_dr_out
The out only version of jtag_add_dr_scan smells like a bogus optimization
that complicates the minidriver API for questionable gain.
The function was only used by four old ARM targets. Rewrite the callers
to use the generic function and remove all implementations.
Change-Id: I13b643687ee8ed6bc9b6336e7096c34f40ea96af
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1801
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/target/arm7tdmi.c')
| -rw-r--r-- | src/target/arm7tdmi.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c index 3dc0013..807efad 100644 --- a/src/target/arm7tdmi.c +++ b/src/target/arm7tdmi.c @@ -95,12 +95,18 @@ static const int arm7tdmi_num_bits[] = {1, 32}; static inline int arm7tdmi_clock_out_inner(struct arm_jtag *jtag_info, uint32_t out, int breakpoint) { - uint32_t values[2] = {breakpoint, flip_u32(out, 32)}; + uint8_t bp = breakpoint ? 1 : 0; + uint8_t out_value[4]; + buf_set_u32(out_value, 0, 32, flip_u32(out, 32)); - jtag_add_dr_out(jtag_info->tap, + struct scan_field fields[2] = { + { .num_bits = arm7tdmi_num_bits[0], .out_value = &bp }, + { .num_bits = arm7tdmi_num_bits[1], .out_value = out_value }, + }; + + jtag_add_dr_scan(jtag_info->tap, 2, - arm7tdmi_num_bits, - values, + fields, TAP_DRPAUSE); jtag_add_runtest(0, TAP_DRPAUSE); |