nds32: drop it, together with aice adapter driver

The target nds32 and its companion adapter aice have not received
any real improvement since 2013.
It has been hard to keep them aligned during the evolution of
OpenOCD code, with no way for maintainers to really check if they
are still working.
No real documentation is present for them in OpenOCD.
The nds32 code triggers ~50 errors/warnings with scan-build.

The arch nds32 has been dropped from Linux kernel v5.18-rc1.

For all the reasons above, this code has been deprecated with
commit 2e5df83de7f2 ("nds32: deprecate it, together with aice
adapter driver") and tagged to be dropped before v0.13.0.

Let it r.i.p. in OpenOCD git history.

While there, drop from checkpatch list the camelcase symbols that
where only used in this code.

Change-Id: Ide52a217f2228e9da2f1cc5036c48f3536f26952
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7382
Tested-by: jenkins

3 files changed, 0 insertions, 62 deletions

diff --git a/src/rtos/FreeRTOS.c b/src/rtos/FreeRTOS.c
index 8403a48..945c4b8 100644
--- a/src/rtos/FreeRTOS.c
+++ b/src/rtos/FreeRTOS.c
@@ -71,20 +71,6 @@ static const struct freertos_params freertos_params_list[] = {
 	&rtos_standard_cortex_m4f_stacking,
 	&rtos_standard_cortex_m4f_fpu_stacking,
 	},
-	{
-	"nds32_v3",			/* target_name */
-	4,						/* thread_count_width; */
-	4,						/* pointer_width; */
-	16,						/* list_next_offset; */
-	20,						/* list_width; */
-	8,						/* list_elem_next_offset; */
-	12,						/* list_elem_content_offset */
-	0,						/* thread_stack_offset; */
-	52,						/* thread_name_offset; */
-	&rtos_standard_nds32_n1068_stacking,	/* stacking_info */
-	&rtos_standard_cortex_m4f_stacking,
-	&rtos_standard_cortex_m4f_fpu_stacking,
-	},
 };
 
 static bool freertos_detect_rtos(struct target *target);
diff --git a/src/rtos/rtos_standard_stackings.c b/src/rtos/rtos_standard_stackings.c
index 5945117..f83f0a1 100644
--- a/src/rtos/rtos_standard_stackings.c
+++ b/src/rtos/rtos_standard_stackings.c
@@ -102,45 +102,6 @@ static const struct stack_register_offset rtos_standard_cortex_r4_stack_offsets[
 	{ 26, 0x04, 32 },		/* CSPR */
 };
 
-static const struct stack_register_offset rtos_standard_nds32_n1068_stack_offsets[] = {
-	{ 0,  0x88, 32 },		/* R0  */
-	{ 1,  0x8C, 32 },		/* R1 */
-	{ 2,  0x14, 32 },		/* R2 */
-	{ 3,  0x18, 32 },		/* R3 */
-	{ 4,  0x1C, 32 },		/* R4 */
-	{ 5,  0x20, 32 },		/* R5 */
-	{ 6,  0x24, 32 },		/* R6 */
-	{ 7,  0x28, 32 },		/* R7 */
-	{ 8,  0x2C, 32 },		/* R8 */
-	{ 9,  0x30, 32 },		/* R9 */
-	{ 10, 0x34, 32 },		/* R10 */
-	{ 11, 0x38, 32 },		/* R11 */
-	{ 12, 0x3C, 32 },		/* R12 */
-	{ 13, 0x40, 32 },		/* R13 */
-	{ 14, 0x44, 32 },		/* R14 */
-	{ 15, 0x48, 32 },		/* R15 */
-	{ 16, 0x4C, 32 },		/* R16 */
-	{ 17, 0x50, 32 },		/* R17 */
-	{ 18, 0x54, 32 },		/* R18 */
-	{ 19, 0x58, 32 },		/* R19 */
-	{ 20, 0x5C, 32 },		/* R20 */
-	{ 21, 0x60, 32 },		/* R21 */
-	{ 22, 0x64, 32 },		/* R22 */
-	{ 23, 0x68, 32 },		/* R23 */
-	{ 24, 0x6C, 32 },		/* R24 */
-	{ 25, 0x70, 32 },		/* R25 */
-	{ 26, 0x74, 32 },		/* R26 */
-	{ 27, 0x78, 32 },		/* R27 */
-	{ 28, 0x7C, 32 },		/* R28 */
-	{ 29, 0x80, 32 },		/* R29 */
-	{ 30, 0x84, 32 },		/* R30 (LP) */
-	{ 31, 0x00, 32 },		/* R31 (SP) */
-	{ 32, 0x04, 32 },		/* PSW */
-	{ 33, 0x08, 32 },		/* IPC */
-	{ 34, 0x0C, 32 },		/* IPSW */
-	{ 35, 0x10, 32 },		/* IFC_LP */
-};
-
 static target_addr_t rtos_generic_stack_align(struct target *target,
 	const uint8_t *stack_data, const struct rtos_register_stacking *stacking,
 	target_addr_t stack_ptr, int align)
@@ -268,11 +229,3 @@ const struct rtos_register_stacking rtos_standard_cortex_r4_stacking = {
 	.calculate_process_stack = rtos_generic_stack_align8,
 	.register_offsets = rtos_standard_cortex_r4_stack_offsets
 };
-
-const struct rtos_register_stacking rtos_standard_nds32_n1068_stacking = {
-	.stack_registers_size = 0x90,
-	.stack_growth_direction = -1,
-	.num_output_registers = 32,
-	.calculate_process_stack = rtos_generic_stack_align8,
-	.register_offsets = rtos_standard_nds32_n1068_stack_offsets
-};
diff --git a/src/rtos/rtos_standard_stackings.h b/src/rtos/rtos_standard_stackings.h
index 83ca07f..2477fff 100644
--- a/src/rtos/rtos_standard_stackings.h
+++ b/src/rtos/rtos_standard_stackings.h
@@ -18,7 +18,6 @@ extern const struct rtos_register_stacking rtos_standard_cortex_m3_stacking;
 extern const struct rtos_register_stacking rtos_standard_cortex_m4f_stacking;
 extern const struct rtos_register_stacking rtos_standard_cortex_m4f_fpu_stacking;
 extern const struct rtos_register_stacking rtos_standard_cortex_r4_stacking;
-extern const struct rtos_register_stacking rtos_standard_nds32_n1068_stacking;
 target_addr_t rtos_generic_stack_align8(struct target *target,
 	const uint8_t *stack_data, const struct rtos_register_stacking *stacking,
 	target_addr_t stack_ptr);