diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2022-12-19 18:18:48 +0100 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2023-03-25 18:13:05 +0000 |
| commit | ff0fdcf61427b76f1cfc9c3ecd551f058c0957d0 (patch) | |
| tree | 2d4c3c6d652bbd8b8b7164d383c41f56ab635437 /src/jtag | |
| parent | 27741252571d7c34b9049275d02cf6c34b1ae7d2 (diff) | |
| download | riscv-openocd-ff0fdcf61427b76f1cfc9c3ecd551f058c0957d0.zip riscv-openocd-ff0fdcf61427b76f1cfc9c3ecd551f058c0957d0.tar.gz riscv-openocd-ff0fdcf61427b76f1cfc9c3ecd551f058c0957d0.tar.bz2 | |
jtag: rewrite command 'jtag arp_init' as COMMAND_HANDLER
While there add the mandatory 'usage' field.
Change-Id: I3491ed79d11c5a3e81cc9afd2423da14b8df72ff
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7495
Tested-by: jenkins
Diffstat (limited to 'src/jtag')
| -rw-r--r-- | src/jtag/tcl.c | 23 |
1 files changed, 7 insertions, 16 deletions
diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index 83cb0a1..f154295 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -664,22 +664,12 @@ static void jtag_tap_handle_event(struct jtag_tap *tap, enum jtag_event e) } } -static int jim_jtag_arp_init(Jim_Interp *interp, int argc, Jim_Obj *const *argv) +COMMAND_HANDLER(handle_jtag_arp_init) { - struct jim_getopt_info goi; - jim_getopt_setup(&goi, interp, argc-1, argv + 1); - if (goi.argc != 0) { - Jim_WrongNumArgs(goi.interp, 1, goi.argv-1, "(no params)"); - return JIM_ERR; - } - struct command_context *context = current_command_context(interp); - int e = jtag_init_inner(context); - if (e != ERROR_OK) { - Jim_Obj *obj = Jim_NewIntObj(goi.interp, e); - Jim_SetResultFormatted(goi.interp, "error: %#s", obj); - return JIM_ERR; - } - return JIM_OK; + if (CMD_ARGC != 0) + return ERROR_COMMAND_SYNTAX_ERROR; + + return jtag_init_inner(CMD_CTX); } static int jim_jtag_arp_init_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv) @@ -843,10 +833,11 @@ static const struct command_registration jtag_subcommand_handlers[] = { { .name = "arp_init", .mode = COMMAND_ANY, - .jim_handler = jim_jtag_arp_init, + .handler = handle_jtag_arp_init, .help = "Validates JTAG scan chain against the list of " "declared TAPs using just the four standard JTAG " "signals.", + .usage = "", }, { .name = "arp_init-reset", |