aboutsummaryrefslogtreecommitdiff
path: root/src/jtag
diff options
context:
space:
mode:
authorStefan Mahr <stefan.mahr@sphairon.com>2013-03-12 10:43:21 +0100
committerSpencer Oliver <spen@spen-soft.co.uk>2013-03-13 12:54:40 +0000
commitfac9057f022e5752fdfbe238ea69219d945d884e (patch)
tree42d54beeb17cd351041bcc34c0134c2c95f5499b /src/jtag
parent02192f6b8c63d740a551e371441d85d59930e65c (diff)
downloadriscv-openocd-fac9057f022e5752fdfbe238ea69219d945d884e.zip
riscv-openocd-fac9057f022e5752fdfbe238ea69219d945d884e.tar.gz
riscv-openocd-fac9057f022e5752fdfbe238ea69219d945d884e.tar.bz2
jtag: parport: avoid freeing read-only memory section
If command parport_cable is not executed, parport_cable points to const char array in read-only memory as default. On exit free() will try to free this read-only memory. This patch uses strdup to allocate memory when defining default setting. Change-Id: I290e707ac6a37e9dc1b45c85ca51d8bd6aac6761 Signed-off-by: Stefan Mahr <stefan.mahr@sphairon.com> Reviewed-on: http://openocd.zylin.com/1223 Tested-by: jenkins Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/jtag')
-rw-r--r--src/jtag/drivers/parport.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/jtag/drivers/parport.c b/src/jtag/drivers/parport.c
index 3c07afb..793b28f 100644
--- a/src/jtag/drivers/parport.c
+++ b/src/jtag/drivers/parport.c
@@ -268,8 +268,8 @@ static int parport_init(void)
cur_cable = cables;
- if ((parport_cable == NULL) || (parport_cable[0] == 0)) {
- parport_cable = "wiggler";
+ if (parport_cable == NULL) {
+ parport_cable = strdup("wiggler");
LOG_WARNING("No parport cable specified, using default 'wiggler'");
}