aboutsummaryrefslogtreecommitdiff
path: root/src/jtag/drivers
diff options
context:
space:
mode:
authorTobias Diedrich <ranma+openocd@tdiedrich.de>2016-08-01 20:29:41 +0200
committerAntonio Borneo <borneo.antonio@gmail.com>2023-11-18 11:29:49 +0000
commit62b526dbbdec073cdcf95bf5cdf622401aa55e78 (patch)
tree97eb2e47632799557336f85b58292947dbf492cb /src/jtag/drivers
parentf55b122b42c212fcb3219e372a7361d6573bd6a3 (diff)
downloadriscv-openocd-62b526dbbdec073cdcf95bf5cdf622401aa55e78.zip
riscv-openocd-62b526dbbdec073cdcf95bf5cdf622401aa55e78.tar.gz
riscv-openocd-62b526dbbdec073cdcf95bf5cdf622401aa55e78.tar.bz2
mips32: MIPS32_OP_SRL was using SRA opcode.
The mips opcode macro for the SRL opcode was using the wrong constant value: SRA -- Shift right arithmetic Encoding: 0000 00-- ---t tttt dddd dhhh hh00 0011 SRL -- Shift right logical Encoding: 0000 00-- ---t tttt dddd dhhh hh00 0010 This corrects the opcode constant for SRL and adds the SRA opcode for completeness. There is only one user of MIPS32_OP_SRL in src/flash/nor/cfi.c: Since the mask constant (0x00000080 for the DQ7 mask) shifted in this case would never have the sign bit set, it worked fine even though it was accidentally using the SRA opcode instead of SRL. Change-Id: I0a80746e2075c7df1ce35b9db00d9d0b997a3feb Signed-off-by: Tobias Diedrich <ranma+openocd@tdiedrich.de> Reviewed-on: https://review.openocd.org/c/openocd/+/3613 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
Diffstat (limited to 'src/jtag/drivers')
0 files changed, 0 insertions, 0 deletions