diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2021-04-25 23:15:36 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2021-05-01 13:37:29 +0100 |
| commit | 1e5782a09a149fe106fa2e574482108f730e4beb (patch) | |
| tree | edc9dacc81f6fbc5ca635545df2cec7e392f1834 /src/jtag/aice/aice_transport.c | |
| parent | 4622a95fcc470d0c1a086ba046abe1f63b139750 (diff) | |
| download | riscv-openocd-1e5782a09a149fe106fa2e574482108f730e4beb.zip riscv-openocd-1e5782a09a149fe106fa2e574482108f730e4beb.tar.gz riscv-openocd-1e5782a09a149fe106fa2e574482108f730e4beb.tar.bz2 | |
jtag: simplify the calls to Jim_SetResultFormatted()
The documentation of Jim_SetResultFormatted() reports that the jim
objects passed as arguments would be freed if have zero refcount.
Remove the useless Jim_IncrRefCount()/Jim_DecrRefCount().
Remove the dangerous Jim_FreeNewObj() that should trigger a double
free(). Not tested due to lack of aice adapter.
While there, rename some CamelCase symbol.
Change-Id: Ic56704c83d6391c38f6b0efa6566784d453bc0fb
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6190
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/jtag/aice/aice_transport.c')
| -rw-r--r-- | src/jtag/aice/aice_transport.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/jtag/aice/aice_transport.c b/src/jtag/aice/aice_transport.c index ea710ad..e3d431b 100644 --- a/src/jtag/aice/aice_transport.c +++ b/src/jtag/aice/aice_transport.c @@ -255,9 +255,8 @@ static int jim_aice_arp_init_reset(Jim_Interp *interp, int argc, Jim_Obj * const e = aice_init_reset(context); if (e != ERROR_OK) { - Jim_Obj *eObj = Jim_NewIntObj(goi.interp, e); - Jim_SetResultFormatted(goi.interp, "error: %#s", eObj); - Jim_FreeNewObj(goi.interp, eObj); + Jim_Obj *obj = Jim_NewIntObj(goi.interp, e); + Jim_SetResultFormatted(goi.interp, "error: %#s", obj); return JIM_ERR; } return JIM_OK; |