diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2023-09-09 09:24:59 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2023-09-17 12:13:01 +0000 |
| commit | 8bbbff185ff97102f7b0db4f1aee7f4d81a06e7d (patch) | |
| tree | bf32fc916f9842b288df2e8629c31f684c62da49 /src/flash/nor | |
| parent | 300fe1d405729aa6bd64bc1287c6c45735624092 (diff) | |
| download | riscv-openocd-8bbbff185ff97102f7b0db4f1aee7f4d81a06e7d.zip riscv-openocd-8bbbff185ff97102f7b0db4f1aee7f4d81a06e7d.tar.gz riscv-openocd-8bbbff185ff97102f7b0db4f1aee7f4d81a06e7d.tar.bz2 | |
flash: npcx: fix memory leak in npcx_flash_bank_command
Recent commit 62f76b216930 ("flash/nor: add support for Nuvoton
NPCX4/K3 series flash") introduces a memory leak for a missing
free() on early return for an error.
Add the free() on the return path on error.
Change-Id: Ica8568a986802e23df2ab7bed4e8cc4bbb6305a5
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: 62f76b216930 ("flash/nor: add support for Nuvoton NPCX4/K3 series flash")
Reviewed-on: https://review.openocd.org/c/openocd/+/7894
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src/flash/nor')
| -rw-r--r-- | src/flash/nor/npcx.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c index 7304a68..4a301f1 100644 --- a/src/flash/nor/npcx.c +++ b/src/flash/nor/npcx.c @@ -321,6 +321,7 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command) npcx_bank->fiu_ver = NPCX_FIU_NPCK; } else { LOG_ERROR("%s is not a valid fiu", fiu); + free(npcx_bank); return ERROR_TARGET_INVALID; } } |