diff options
| author | Tomas Vanek <vanekt@fbl.cz> | 2024-03-10 12:12:55 +0100 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2024-03-10 17:54:52 +0000 |
| commit | 12ff36bd19e4f25dd7505c46a77d9f2c47dc350a (patch) | |
| tree | 435f7c0906663a9b8c6c21f9af3ca6c302a6a50e /src/flash/nor/nrf5.c | |
| parent | 561ea48d83ae4b83ff823888a80cbcc282b61333 (diff) | |
| download | riscv-openocd-12ff36bd19e4f25dd7505c46a77d9f2c47dc350a.zip riscv-openocd-12ff36bd19e4f25dd7505c46a77d9f2c47dc350a.tar.gz riscv-openocd-12ff36bd19e4f25dd7505c46a77d9f2c47dc350a.tar.bz2 | |
flash/nor/nrf5: drop useless for cycle condition
Commit [1] added a break on error to the nrf5_erase() sector loop
and the checking of the res value became useless in the for loop condition.
Removing nrf5_get_probed_chip_if_halted() later in [2]
dropped res initialization and clang static analyser complains
"The left operand of '==' is a garbage value"
Drop the useless test!
Fixes: [1] commit 491636c8b832 ("flash/nor/nrf5: check protection before flash erase/write on nRF51")
Fixes: [2] commit 2db325f5395f ("flash/nor/nrf5: drop nrf5_get_probed_chip_if_halted()")
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Change-Id: Ife6071c509719f8d7dc312fe9a780bdcf2575f69
Reviewed-on: https://review.openocd.org/c/openocd/+/8174
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Diffstat (limited to 'src/flash/nor/nrf5.c')
| -rw-r--r-- | src/flash/nor/nrf5.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/flash/nor/nrf5.c b/src/flash/nor/nrf5.c index 3f451a7..bf8c9da 100644 --- a/src/flash/nor/nrf5.c +++ b/src/flash/nor/nrf5.c @@ -1071,7 +1071,7 @@ static int nrf5_erase(struct flash_bank *bank, unsigned int first, } /* For each sector to be erased */ - for (unsigned int s = first; s <= last && res == ERROR_OK; s++) { + for (unsigned int s = first; s <= last; s++) { if (chip->features & NRF5_FEATURE_SERIES_51 && bank->sectors[s].is_protected == 1) { |