aboutsummaryrefslogtreecommitdiff
path: root/HACKING
diff options
context:
space:
mode:
authorAntonio Borneo <borneo.antonio@gmail.com>2022-11-16 23:06:12 +0100
committerAntonio Borneo <borneo.antonio@gmail.com>2022-12-03 09:25:27 +0000
commit3ea1bfce4faf656d0506c194084807f1e498abff (patch)
treec01612d7d95dddb021dc7fc52712c5883331039b /HACKING
parent0f034868f2c90741e57c5e27121e292b1774c080 (diff)
downloadriscv-openocd-3ea1bfce4faf656d0506c194084807f1e498abff.zip
riscv-openocd-3ea1bfce4faf656d0506c194084807f1e498abff.tar.gz
riscv-openocd-3ea1bfce4faf656d0506c194084807f1e498abff.tar.bz2
jtag: xds110: fix clang error core.StackAddressEscape
Clang ignores that xds110_swd_write_reg() is always called with bit SWD_CMD_RNW in 'cmd' set to zero. It then complains that the local variable 'value' gets passed by address to xds110_swd_queue_cmd() and in case of 'read request' such stack address get stored for later use: src/jtag/drivers/xds110.c:1363:1: warning: Address of stack memory associated with local variable 'value' is still referred to by the global variable 'xds110' upon returning to the caller. This will be a dangling reference [core.StackAddressEscape] To both xds110_swd_write_reg() and xds110_swd_read_reg(), add an assert() to inform Clang about the state of bit SWD_CMD_RNW. Change-Id: I7687c055ec71424b642e152f478723a930966e3a Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/7380 Tested-by: jenkins
Diffstat (limited to 'HACKING')
0 files changed, 0 insertions, 0 deletions