aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntonio Borneo <borneo.antonio@gmail.com>2023-05-01 00:55:15 +0200
committerAntonio Borneo <borneo.antonio@gmail.com>2023-05-18 10:09:57 +0000
commitfaf7202f8ee65f21a96ea1ebf33f7157c97065f0 (patch)
tree0017ed3f426c707106ba70e9759da3dbdd2eb2db
parentea530015b0f69d7a0e3ee3dca6fb69554e6d2046 (diff)
downloadriscv-openocd-faf7202f8ee65f21a96ea1ebf33f7157c97065f0.zip
riscv-openocd-faf7202f8ee65f21a96ea1ebf33f7157c97065f0.tar.gz
riscv-openocd-faf7202f8ee65f21a96ea1ebf33f7157c97065f0.tar.bz2
nand: declare exported function in core.h
Don't use 'extern' in a C file, but declare the exported function in a H file. This helps validating the function prototype across declaration and use. Detected through 'sparse' tool. Change-Id: I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/7666 Tested-by: jenkins
-rw-r--r--src/flash/nand/core.h2
-rw-r--r--src/flash/nand/lpc32xx.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/flash/nand/core.h b/src/flash/nand/core.h
index 19c53d1..8f54493 100644
--- a/src/flash/nand/core.h
+++ b/src/flash/nand/core.h
@@ -202,6 +202,8 @@ int nand_calculate_ecc(struct nand_device *nand,
const uint8_t *dat, uint8_t *ecc_code);
int nand_calculate_ecc_kw(struct nand_device *nand,
const uint8_t *dat, uint8_t *ecc_code);
+int nand_correct_data(struct nand_device *nand, u_char *dat,
+ u_char *read_ecc, u_char *calc_ecc);
int nand_register_commands(struct command_context *cmd_ctx);
diff --git a/src/flash/nand/lpc32xx.c b/src/flash/nand/lpc32xx.c
index f8b59b3..1fdae9f 100644
--- a/src/flash/nand/lpc32xx.c
+++ b/src/flash/nand/lpc32xx.c
@@ -24,8 +24,6 @@
static int lpc32xx_reset(struct nand_device *nand);
static int lpc32xx_controller_ready(struct nand_device *nand, int timeout);
static int lpc32xx_tc_ready(struct nand_device *nand, int timeout);
-extern int nand_correct_data(struct nand_device *nand, u_char *dat,
- u_char *read_ecc, u_char *calc_ecc);
/* These are offset with the working area in IRAM when using DMA to
* read/write data to the SLC controller.