aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntonio Borneo <borneo.antonio@gmail.com>2022-09-19 14:50:26 +0200
committerAntonio Borneo <borneo.antonio@gmail.com>2022-09-23 21:22:42 +0000
commitaa57890554cb4f8b4ccf35a69598238a12a79069 (patch)
tree3a8e12c420a8a7880eb683916e38f339f93463b1
parent8db6dff333c2803d339086c7d5694eac4da11d0a (diff)
downloadriscv-openocd-aa57890554cb4f8b4ccf35a69598238a12a79069.zip
riscv-openocd-aa57890554cb4f8b4ccf35a69598238a12a79069.tar.gz
riscv-openocd-aa57890554cb4f8b4ccf35a69598238a12a79069.tar.bz2
target/riscv-013: fix unused initialization
Scan-build reports: Unused code: Dead initialization riscv-013.c:2362 Value stored to 'control' during its initialization is never read Remove the initialization of variable 'control'. Change-Id: I548f8175530b9a2aa4c1788549d6467bf9824584 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/7206 Reviewed-by: Tim Newsome <tim@sifive.com> Reviewed-by: Jan Matyas <matyas@codasip.com> Tested-by: jenkins
-rw-r--r--src/target/riscv/riscv-013.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
index 1f4c343..99d3873 100644
--- a/src/target/riscv/riscv-013.c
+++ b/src/target/riscv/riscv-013.c
@@ -2359,9 +2359,7 @@ static int assert_reset(struct target *target)
/* TODO: Try to use hasel in dmcontrol */
/* Set haltreq for each hart. */
- uint32_t control = control_base;
-
- control = set_hartsel(control_base, target->coreid);
+ uint32_t control = set_hartsel(control_base, target->coreid);
control = set_field(control, DM_DMCONTROL_HALTREQ,
target->reset_halt ? 1 : 0);
dmi_write(target, DM_DMCONTROL, control);