diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2020-05-13 16:51:00 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2021-04-18 15:35:03 +0100 |
| commit | 6b5e77ada6520398f9a2135e43e60067bc072e27 (patch) | |
| tree | 1e26a6055459b24ca469d8d040c850c326dfb98a | |
| parent | fa23b1a71e4f1974791e90055c301f9bf124e835 (diff) | |
| download | riscv-openocd-6b5e77ada6520398f9a2135e43e60067bc072e27.zip riscv-openocd-6b5e77ada6520398f9a2135e43e60067bc072e27.tar.gz riscv-openocd-6b5e77ada6520398f9a2135e43e60067bc072e27.tar.bz2 | |
helper/command: make script_debug() static
Now that all commands are executed through the common handler
command_unknown(), the message about command execution is logged
by command_unknown(). There is no need, for "native" commands
(.jim_handler) at root level to log the message (again) by itself.
Remove calls to script_debug() apart from command_unknown().
Make script_debug() static as only used in command.c.
Change-Id: I9b2728b69e7643d6121c4b35a96bc825bcb5488d
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5676
Tested-by: jenkins
Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
| -rw-r--r-- | src/helper/command.c | 2 | ||||
| -rw-r--r-- | src/helper/command.h | 2 | ||||
| -rw-r--r-- | src/jtag/tcl.c | 6 |
3 files changed, 1 insertions, 9 deletions
diff --git a/src/helper/command.c b/src/helper/command.c index 630630f..a7990d4 100644 --- a/src/helper/command.c +++ b/src/helper/command.c @@ -180,7 +180,7 @@ extern struct command_context *global_cmd_ctx; /* dump a single line to the log for the command. * Do nothing in case we are not at debug level 3 */ -void script_debug(Jim_Interp *interp, unsigned int argc, Jim_Obj * const *argv) +static void script_debug(Jim_Interp *interp, unsigned int argc, Jim_Obj * const *argv) { if (debug_level < LOG_LVL_DEBUG) return; diff --git a/src/helper/command.h b/src/helper/command.h index 1f2dc5b..68f4c14 100644 --- a/src/helper/command.h +++ b/src/helper/command.h @@ -456,6 +456,4 @@ COMMAND_HELPER(handle_command_parse_bool, bool *out, const char *label); #define COMMAND_PARSE_ENABLE(in, out) \ COMMAND_PARSE_BOOL(in, out, "enable", "disable") -void script_debug(Jim_Interp *interp, unsigned int argc, Jim_Obj * const *argv); - #endif /* OPENOCD_HELPER_COMMAND_H */ diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index bf65e81..3e73335 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -108,8 +108,6 @@ static int Jim_Command_drscan(Jim_Interp *interp, int argc, Jim_Obj *const *args endstate = TAP_IDLE; - script_debug(interp, argc, args); - /* validate arguments as numbers */ e = JIM_OK; for (i = 2; i < argc; i += 2) { @@ -234,8 +232,6 @@ static int Jim_Command_pathmove(Jim_Interp *interp, int argc, Jim_Obj *const *ar return JIM_ERR; } - script_debug(interp, argc, args); - int i; for (i = 0; i < argc-1; i++) { const char *cp; @@ -266,8 +262,6 @@ static int Jim_Command_pathmove(Jim_Interp *interp, int argc, Jim_Obj *const *ar static int Jim_Command_flush_count(Jim_Interp *interp, int argc, Jim_Obj *const *args) { - script_debug(interp, argc, args); - Jim_SetResult(interp, Jim_NewIntObj(interp, jtag_get_flush_queue_count())); return JIM_OK; |