diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2023-04-09 01:00:15 +0200 |
|---|---|---|
| committer | Antonio Borneo <borneo.antonio@gmail.com> | 2023-05-06 13:34:32 +0000 |
| commit | 329b10754aa2294d11717c461f356c174eba5094 (patch) | |
| tree | a1b2b0b1eea8ecd3dc271d9d903d8dd9ab374954 | |
| parent | 92c1bee18c8268511de3478aabd226ce4f92322a (diff) | |
| download | riscv-openocd-329b10754aa2294d11717c461f356c174eba5094.zip riscv-openocd-329b10754aa2294d11717c461f356c174eba5094.tar.gz riscv-openocd-329b10754aa2294d11717c461f356c174eba5094.tar.bz2 | |
target: etm: fix check trace status
Current code tests a function pointer against a numeric value that
is the same enum type as returned by the pointed function.
Clearly the author was willing to call the function and check its
returned value.
Fix the check by calling the function.
Detected through 'sparse' tool.
Change-Id: I27d18d26c2c797160a397daa32835c199014b70b
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Checkpatch-ignore: GIT_COMMIT_ID
Fixes: 237e894805dd ("reworked etm/etb into a generic etm part with trace capture")
Reviewed-on: https://review.openocd.org/c/openocd/+/7599
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
| -rw-r--r-- | src/target/etm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/target/etm.c b/src/target/etm.c index 57417c3..6718875 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -1706,7 +1706,7 @@ COMMAND_HANDLER(handle_etm_dump_command) return ERROR_FAIL; } - if (etm_ctx->capture_driver->status == TRACE_IDLE) { + if (etm_ctx->capture_driver->status(etm_ctx) == TRACE_IDLE) { command_print(CMD, "trace capture wasn't enabled, no trace data captured"); return ERROR_OK; } |