diff options
| author | Antonio Borneo <borneo.antonio@gmail.com> | 2019-02-13 18:28:50 +0100 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2019-06-06 16:33:41 +0100 |
| commit | 0cba5b4ea30a436e1ab381b374ea89743a23e09c (patch) | |
| tree | dc3015ffafe63a5bed43f9311248406c83025378 | |
| parent | 02cd1e39cc710a6a6592486238c15f7b42c7d21c (diff) | |
| download | riscv-openocd-0cba5b4ea30a436e1ab381b374ea89743a23e09c.zip riscv-openocd-0cba5b4ea30a436e1ab381b374ea89743a23e09c.tar.gz riscv-openocd-0cba5b4ea30a436e1ab381b374ea89743a23e09c.tar.bz2 | |
gdb_server: remove call to jtag_execute_queue()
In the initial commit 6c9b804d6187edda4f46f8458deec0b17ec76bb9
in 2007's svn://svn.berlios.de/openocd/trunk@246
a target script gdb_program_config was called before gdb flash
programming. To guarantee the script does not left any pending
command in the jtag queue, a call to jtag_execute_queue() was
inserted after the execution of the script.
In following commit ef1cfb23947bd32798077c6abb5c25a049460ae9
in 2008's svn://svn.berlios.de/openocd/trunk@975
the script was replaced by the event "old-gdb_program_config" and
the call to jtag_execute_queue() get executed in every case, even
if the event handler was not present.
At last, commit bb3793c9a4ccd232c4ee3ce0a36bf200589ca0bb
("target: remove legacy target events") stripped away the
obsolete event but left the call to jtag_execute_queue(), now
completely useless.
Remove the call to jtag_execute_queue() and clean-up the code
around it.
Change-Id: I284f54d656d431ad6cdc25ca18218c09db31bd25
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4911
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
| -rw-r--r-- | src/server/gdb_server.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c index 60ed4ce..ab3e6be 100644 --- a/src/server/gdb_server.c +++ b/src/server/gdb_server.c @@ -903,7 +903,6 @@ static void gdb_frontend_halted(struct target *target, struct connection *connec static int gdb_target_callback_event_handler(struct target *target, enum target_event event, void *priv) { - int retval; struct connection *connection = priv; struct gdb_service *gdb_service = connection->service->priv; @@ -917,11 +916,6 @@ static int gdb_target_callback_event_handler(struct target *target, case TARGET_EVENT_HALTED: target_call_event_callbacks(target, TARGET_EVENT_GDB_END); break; - case TARGET_EVENT_GDB_FLASH_ERASE_START: - retval = jtag_execute_queue(); - if (retval != ERROR_OK) - return retval; - break; default: break; } |