aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-12-22configure.ac: switch from $host to $host_osR. Diez1-4/+4
Suggested during review https://review.openocd.org/c/openocd/+/8533 Only the OS part was being checked anyway. The aim is to facilitate merging all $host_os checks in the future. Change-Id: Idce1d5872cf19ef423429fa0c3b2ff7ee3945332 Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8607 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
2024-12-22configure.ac: enable the Dummy adapter by defaultR. Diez1-2/+1
The Dummy adapter is useful when developing generic JimTcl code. Besides, the distributed BUGS file states that you should try to reproduce any crashes with the Dummy adapter, so it does not make sense that it is not enabled by default. Change-Id: I145de06de4d2c0011619b1b941200b63e200db23 Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8608 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins Reviewed-by: Paul Fertser <fercerpav@gmail.com>
2024-12-22rtos: mqx: minor rework to avoid a castAntonio Borneo1-2/+2
Change the type of task_name[] to char in order to drop a cast. Change-Id: I233fc862e972e52130fd4ffcb29a3da36f4f8923 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8599 Reviewed-by: Paul Fertser <fercerpav@gmail.com> Tested-by: jenkins
2024-12-22rtos: mqx: replace malloc+strcpy with strdupPaul Fertser1-2/+1
Using strcpy is potentially dangerous so just use a safer and easier way to do the same. Signed-off-by: Paul Fertser <fercerpav@gmail.com> Change-Id: Id85f3b7f8af1eaf14c9951ae710546d2437c70b5 Reviewed-on: https://review.openocd.org/c/openocd/+/8597 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
2024-12-22target: aarch64: fix out-of-bound access to arrayAntonio Borneo1-4/+18
The command 'arm core_state' uses the enum in 'arm->core_state' as an index in the table of strings to print the core state. With [1] the enum has been extended with the new state for AArch64 but not the corresponding table of strings. This causes an access after the limit of arm_state_strings[]. Rewrite the table using c99 array designators to better show the link between the enum list and the table. Add the function arm_core_state_string() to check for out-of-bound values allover the file. Change-Id: I06473c2c8088b38ee07118bcc9e49bc8eafbc6e2 Fixes: [1] 9cbfc9feb35c ("arm_dpm: Add new state ARM_STATE_AARCH64") Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8594 Tested-by: jenkins
2024-12-22doc/manual: Add section about loggingMarc Schink1-0/+15
The log messages are very inconsistent across the code base. Add a guideline for log messages to help improve consistency. The guideline is based on the most commonly used style in the current code base. Change-Id: I076d68abe588dd04b59580379e97b82d537def23 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8576 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
2024-12-22rtt server: fix for dropped data when target has no spacefanoush1-15/+54
rtt_write_channel may write less data than requested, default device buffer size for channel 0 is 16 bytes, so currently anything larger than this is dropped. This fix implements per connection buffer and uses the connection->input_pending flag to retry writes. Change-Id: I00c845fccb0248550ad0f0fd9cda7bac7976b92b Signed-off-by: fanoush <fanoush@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8360 Reviewed-by: zapb <dev@zapb.de> Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-12-22jimtcl: Fix command not foundPete Moore1-1/+1
During the ./configure build stage, error './configure.gnu: line 1: -e: command not found' can occur. Problem: the -e flag with echo is not portable. While some shells support it (e.g., Bash), others (e.g., POSIX /bin/sh on some systems) do not. Solution: replacing echo -e with printf, since printf is POSIX-compliant and works consistently across different shells. Change-Id: I9efbba662599a61bbe1fc56a33dc1ee7ad58826c Signed-off-by: Pete Moore <pmoore@mozilla.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8653 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
2024-12-21flash/nor/sfdp: Fix broken DEBUG log line on macOSPete Moore1-1/+1
https://review.openocd.org/c/openocd/+/8439 changed variable `words` from uint8_t to unsigned int in sfdp.c but failed to update the LOG_DEBUG line to reflect the new type. On macOS this caused: src/flash/nor/sfdp.c:107:28: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat] The formatting of the debug line has been updated to reflect the updated type. Change-Id: Ifc7ddb1279ab2603901c969d9c09af847f3a3caf Signed-off-by: Pete Moore <pmoore@mozilla.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8660 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-12-20Merge pull request #1186 from en-sc/en-sc/from_upstreamEvgeniy Naydanov47-193/+212
Merge up to 133dd9d669e5b8beb7c7787b0be677621808e72d from upstream
2024-12-18Merge up to 133dd9d669e5b8beb7c7787b0be677621808e72d from upstreamEvgeniy Naydanov47-193/+212
Change-Id: Iaaf234da839cbed61684f4615135c9a42213c56a
2024-12-11Merge pull request #1181 from en-sc/en-sc/reg-invalidateEvgeniy Naydanov5-21/+80
target/riscv: clean-up register invalidation
2024-12-11Merge pull request #1183 from fk-sc/fk-sc/ternary-operatorEvgeniy Naydanov1-33/+40
target/riscv: replaced repeating ternary operator with variable
2024-12-10target/riscv: clean-up register invalidationEvgeniy Naydanov5-21/+80
* Registers were not invalidated if the hart became unavailable. * Improved logging in the case register invalidation involves loss of information. Change-Id: Icfb5e190dd6dcb1a97e4d314d802466cab7a01e4 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
2024-12-10target/riscv: replaced repeating ternary operator with variableFarid Khaydari1-33/+40
Replaced repeating ternary operator with variable Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
2024-12-06Merge pull request #1173 from fk-sc/buf-getEvgeniy Naydanov1-20/+8
target/riscv: use buf_get_uXX instead of manual bit shift
2024-12-04target/riscv: use buf_get_uXX instead of manual bit shiftFarid Khaydari1-20/+8
Replaced manual bit shift with buf_get_u64/buf_get_u32 Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
2024-12-04Merge pull request #1167 from fk-sc/fk-sc/rwargsAnatoly Parshintsev4-293/+420
target/riscv: pass memory access info in struct, move write_memory pointer
2024-11-29Merge pull request #1176 from aap-sc/aap-sc/csr_as_hex_regression_fixupAnatoly Parshintsev1-1/+5
fix incorrect parsing of names for custom csr registers
2024-11-29target/riscv: pass memory access info in struct, move write_memory pointerFarid Khaydari4-293/+420
This changes will allow to unite read_memory/write_memory fucntions to one access function (1) Replaced read/write functions arguments with one structure (2) Unified read_memory/write_memory function pointers to be stored in same structure Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
2024-11-29Merge pull request #1174 from fk-sc/fk-sc/checker-fixAnatoly Parshintsev1-4/+10
target/riscv: fix memory access result type checker function return in case of assertion
2024-11-27fix incorrect parsing of names for custom csr registersParshintsev Anatoly1-1/+5
this commit fixes a regression introduced in ba8c1eef5a32193d9b5dc80d681a4f18d1d94f11. The regression was caused by removal of these lines: ``` - /* Register prefix: "csr_" or "custom_" */ - strcpy(name, reg_type); - name[strlen(reg_type)] = '_'; ``` causing all CSR names with custom names to be parsed as empty strings.
2024-11-26Merge pull request #1170 from fk-sc/fk-sc/priv-modEvgeniy Naydanov1-23/+35
target/riscv: decrease modify_privilege function nesting level
2024-11-26target/riscv: fix memory access result type checker function return in case ↵Farid Khaydari1-4/+10
of assertion Fix memory access result type checker return in case of assertion Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
2024-11-25Merge pull request #1162 from aap-sc/aap-sc/csr_as_hexAnatoly Parshintsev1-50/+81
target/riscv: allow hexadecimal values to expose_csr-like commands
2024-11-23target/xtensa: add maskisr command support for NXHenrik Mau2-18/+24
Add maskisr command support to Xtensa NX targets allowing masking of interrupts during single stepping. Change-Id: I3835479de8015f1a2842afd1aeab24829e385031 Signed-off-by: Henrik Mau <henrik.mau@analog.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8575 Reviewed-by: Ian Thompson <ianst@cadence.com> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
2024-11-23target/cortex_m: Use LOG_TARGET_xxx()Marc Schink1-5/+5
Use LOG_TARGET_xxx() for the remaining log messages. Change-Id: If52e3935b57e4c39212ce6b5111ff65159de1373 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8580 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23target/breakpoints: Use LOG_TARGET_ERROR()Marc Schink1-3/+2
Use LOG_TARGET_xxx() for the remaining log messages. Change-Id: I4b86b206d17dead0662388e827204b40a7d29edd Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8579 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23rtos: Remove 'ERROR: ' prefix in error logMarc Schink1-1/+1
Remove the prefix since it is redundant. While at it, also get rid of the useless exclamation mark. Change-Id: I8707342c602cea735c5a423b37ebe40a3aafb137 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8578 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23target/xtensa: Remove 'ERROR: ' prefix in error logMarc Schink1-3/+3
Remove the prefix since it is redundant. Change-Id: I9c23c0479ba40be24e471309e720060cd03763ee Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8577 Tested-by: jenkins Reviewed-by: Ian Thompson <ianst@cadence.com> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23configure.ac: improve validation of some --enable-xxx optionsR. Diez1-2/+6
Catch an invalid option like "--enable-buspirate=rubbish". Also mention all valid values in the help text for those options. Change-Id: Ib0fb8904132d07cc5cde421aa816ca6971a08769 Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8540 Reviewed-by: R. Diez <rdiez-2006@rd10.de> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
2024-11-23configure.ac: show the linuxgpiod adapter in the configuration summaryR. Diez1-6/+7
List AC_ARG_ADAPTERS was missing a comma separating two of the elements. Also verify that each adapter is set to either 'auto', 'yes' or 'no', which should prevent such issues from going unnoticed in the future. Change-Id: I0d407e03b1e5a3edc61d7dc93d5ffa70fe079b3c Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8534 Tested-by: jenkins Reviewed-by: R. Diez <rdiez-2006@rd10.de> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23enable the Bus Pirate adapter by default on most systemsR. Diez3-13/+10
Also convert the Bus Pirate to the common PROCESS_ADAPTERS logic. Change-Id: Ifa8ebcee380c16d7e308ba7a75dbffdb74208285 Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8533 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: R. Diez <rdiez-2006@rd10.de> Tested-by: jenkins
2024-11-23driver: stlink: get adapter speed through adapter_get_speed_khz()Antonio Borneo3-9/+2
The stlink driver, both in dapdirect and in HLA modes, pretends to store locally the value of the adapter speed in order to use it later-on during adapter initialization. It doesn't work in dapdirect mode since the code to store locally the value will not be executed until the adapter is already fully initialized. This cause an issue in dapdirect mode: - due to the local value, still kept at -1, the adapter will be initialized to the lowest clock speed (5 KHz on stlink v2 in SWD mode); - after the adapter initialization the framework will again set the speed with the value requested by the user. Some target, like nRF51822, only accepts JTAG/SWD speed in a defined range of frequencies. The initial speed of 5 KHz used by dapdirect can be out of range, making the target debug port not working. The adapter framework already stores the value of speed and makes it available through adapter_get_speed_khz(). Drop struct hl_interface_param::initial_interface_speed. Let the code to use adapter_get_speed_khz(). Change-Id: Ie11bf0234574f2a9180d3d3a16efb78e08dfcd86 Reported-by: Andrzej Sierżęga <asier70@gmail.com> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8574 Reviewed-by: Andrzej Sierżęga <asier70@gmail.com> Tested-by: jenkins
2024-11-23helper/jim-nvp.h: Rework 'isconfigure' variableMarc Schink7-33/+34
Change the variable name to 'is_configure' to be compatible with the coding style and use 'bool' as data type. Change-Id: I8609f9807c8bd14eaf6c93acf63fd51b55c9bbbb Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/8573 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
2024-11-23semihosting: make local functions staticAntonio Borneo2-18/+10
The functions: - semihosting_opcode_to_str(); - semihosting_write_fields(); - semihosting_set_field(); are not referenced outside the file. Make them static. Change-Id: Ia8d35554673145fdfe0e501543eb18919863039f Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8551 Tested-by: jenkins
2024-11-23target: esirisc: make local functions staticAntonio Borneo2-4/+4
The function esirisc_jtag_get_eid() is not used outside the file. Make it static. The function esirisc_jtag_disable_debug() is never used. Make it static and mark it as unused. Change-Id: I5c99cbf77cc9c527b6e18a3f67caa24f8551d09c Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8550 Tested-by: jenkins
2024-11-23target: aarch64: drop unused armv8_mmu_translate_va()Antonio Borneo2-7/+0
The function is not used. Drop it! Change-Id: I1625e03714b5a842f668098191c39cce34f815e8 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8549 Tested-by: jenkins
2024-11-23target: x86_32: make x86_32_common_read_io() staticAntonio Borneo2-3/+1
The function is not referenced outside the file. Make it static. Change-Id: Ic2552c040b6b46c0334851a4fc0fdaa400e11e4c Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8548 Tested-by: jenkins
2024-11-23target: dsp563xx: make dsp563xx_once_reg_read_ex() staticAntonio Borneo2-3/+3
The function is not referenced outside the file. Make it static. Change-Id: Ifeccc5e38f3da4b4111422860bc1c1447d00f7fe Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8547 Tested-by: jenkins
2024-11-23pld: make get_pld_device_by_num() staticAntonio Borneo2-2/+1
The function is not referenced outside the file. Make it static. Change-Id: I5f2a2c70085b9158df8806432bb9ed09bb256ab5 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8546 Tested-by: jenkins
2024-11-23rtt: drop unused function rtt_started()Antonio Borneo2-12/+0
The function is not used. Drop it! Change-Id: I176c9d6ba077e36b762c14f9b877d5152992763c Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8545 Tested-by: jenkins Reviewed-by: zapb <dev@zapb.de>
2024-11-23driver: mpsse: make local functions staticAntonio Borneo2-8/+6
The functions: - mpsse_divide_by_5_config(); - mpsse_purge(); - mpsse_rtck_config(); - mpsse_set_divisor(); are not referenced outside the file. Make them static. Change-Id: Id6930183a3ce26693b2113f622046168ba289df8 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8544 Tested-by: jenkins
2024-11-23jtag: driver: make local functions staticAntonio Borneo2-8/+2
The functions: - interface_jtag_add_callback(); - interface_jtag_add_callback4(); are not referenced outside the file. Make them static. Change-Id: I84f738309d23c8d0b5329aa04436db750cf185e5 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8543 Tested-by: jenkins
2024-11-23jtag: core: make local functions staticAntonio Borneo2-8/+8
The functions: - jtag_error_clear(); - jtag_tap_count(); are not referenced outside the file. Make them static. Change-Id: I00fcf06b1838b9f6c955c19772f1d41d486459e9 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8542 Tested-by: jenkins
2024-11-23adapter: make adapter_config_khz() staticAntonio Borneo2-4/+4
The function is not referenced outside the file. Make it static. Change-Id: I72e96624749ae4cc7f4566d737a88186e899616a Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8541 Tested-by: jenkins
2024-11-23gitignore: drop ignoring files not generated anymoreAntonio Borneo1-4/+0
With the drop of the code for the probe zy1000 [1] and then the drop of minidriver code [2], there are no more auto-generated source files. Remove them from the list of generated files to be ignored. Change-Id: Iee65e21528674ea4cc94018e52126f882da4f07c Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> [1] b0fe92dba7c0 ("zy1000: drop the code, deprecated in v0.10.0") [2] 25218e893503 ("jtag: remove minidriver code and minidriver-dummy") Reviewed-on: https://review.openocd.org/c/openocd/+/8522 Tested-by: jenkins
2024-11-21Merge pull request #1144 from sunnyzhu-learning/resume-before-step-developEvgeniy Naydanov2-12/+115
target/riscv:Perform single step before resume if necessary
2024-11-21target/riscv: decrease modify_privilege function nesting levelFarid Khaydari1-23/+35
Restructured modify_privilege function to decrease nesting level Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
2024-11-19target/riscv: allow hexadecimal values to expose_csr-like commandsParshintsev Anatoly1-50/+81
hexadecimal values are often used in the documentation. Forcing user to convert CSRs addresses to decimal is unnecessary.
generated by cgit v1.1 at 2025-09-20 17:40:52 +0000