diff options
| author | Tim Newsome <tim@sifive.com> | 2022-05-06 09:57:14 -0700 |
|---|---|---|
| committer | Tim Newsome <tim@sifive.com> | 2022-05-06 09:57:14 -0700 |
| commit | 103c1bc9226054565d0c613096e33a623f93e50a (patch) | |
| tree | 57a3ec62944e437f5dd4905dd0de4cda048144f0 | |
| parent | ecd736dc53e7dac43fbe358aea5e7639cbfeb7ee (diff) | |
| download | riscv-openocd-103c1bc9226054565d0c613096e33a623f93e50a.zip riscv-openocd-103c1bc9226054565d0c613096e33a623f93e50a.tar.gz riscv-openocd-103c1bc9226054565d0c613096e33a623f93e50a.tar.bz2 | |
Style changes suggested in review.set_group
Change-Id: I29e83d3dbef09cb971ec0355aff733191a6e4679
Signed-off-by: Tim Newsome <tim@sifive.com>
| -rw-r--r-- | src/target/riscv/riscv-013.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c index 99ecc00..7eb206f 100644 --- a/src/target/riscv/riscv-013.c +++ b/src/target/riscv/riscv-013.c @@ -1509,14 +1509,16 @@ typedef enum { } grouptype_t; static int set_group(struct target *target, bool *supported, unsigned group, grouptype_t grouptype) { - uint32_t write = set_field(DM_DMCS2_HGWRITE, DM_DMCS2_GROUP, group); - write = set_field(write, DM_DMCS2_GROUPTYPE, (grouptype == HALTGROUP) ? 1 : 0); - if (dmi_write(target, DM_DMCS2, write) != ERROR_OK) + uint32_t write_val = DM_DMCS2_HGWRITE; + assert(group <= 31); + write_val = set_field(write_val, DM_DMCS2_GROUP, group); + write_val = set_field(write_val, DM_DMCS2_GROUPTYPE, (grouptype == HALTGROUP) ? 1 : 0); + if (dmi_write(target, DM_DMCS2, write_val) != ERROR_OK) return ERROR_FAIL; - uint32_t read; - if (dmi_read(target, &read, DM_DMCS2) != ERROR_OK) + uint32_t read_val; + if (dmi_read(target, &read_val, DM_DMCS2) != ERROR_OK) return ERROR_FAIL; - *supported = get_field(read, DM_DMCS2_GROUP) == group; + *supported = get_field(read_val, DM_DMCS2_GROUP) == group; return ERROR_OK; } |