diff options
| author | Seth LaForge <sethml@google.com> | 2019-09-12 09:18:45 -0700 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2019-09-24 05:47:43 +0100 |
| commit | 31100927203a4e9d5e4f8e019b1a9e1c9d7b51c6 (patch) | |
| tree | 875d8fae9b570b39a0ce26d9d537f033e1cb11e6 | |
| parent | 31a3324b68827ed7fd6c545d04373b63bd828d6b (diff) | |
| download | riscv-openocd-31100927203a4e9d5e4f8e019b1a9e1c9d7b51c6.zip riscv-openocd-31100927203a4e9d5e4f8e019b1a9e1c9d7b51c6.tar.gz riscv-openocd-31100927203a4e9d5e4f8e019b1a9e1c9d7b51c6.tar.bz2 | |
src/jtag/aice: Fix obviously incorrect bit op.
Fix expression "(pin_status | 0x4)" which was always true rather than
testing a bit. Untested - was clearly not expressing the intent of the
author by inspection. Found by automated tooling and rtrieu@google.com.
Signed-off-by: Seth LaForge <sethml@google.com>
Change-Id: I4bb91e60e8ce9757bf21976cc48de6f85a39c68d
Reviewed-on: http://openocd.zylin.com/5301
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
| -rw-r--r-- | src/jtag/aice/aice_usb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/jtag/aice/aice_usb.c b/src/jtag/aice/aice_usb.c index af08ace..324ec7c 100644 --- a/src/jtag/aice/aice_usb.c +++ b/src/jtag/aice/aice_usb.c @@ -2812,7 +2812,7 @@ static int aice_issue_reset_hold(uint32_t coreid) /* set no_dbgi_pin to 0 */ uint32_t pin_status; aice_read_ctrl(AICE_READ_CTRL_GET_JTAG_PIN_STATUS, &pin_status); - if (pin_status | 0x4) + if (pin_status & 0x4) aice_write_ctrl(AICE_WRITE_CTRL_JTAG_PIN_STATUS, pin_status & (~0x4)); /* issue restart */ |