diff options
| author | Victoriano Morales <victoriano.morales@openchip.com> | 2026-02-19 08:34:27 +0000 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2026-03-09 13:50:42 +0530 |
| commit | 4dc1b9f7baac61cb49e9f6b58ebea73cbd663500 (patch) | |
| tree | 0473e77d2d291a12ad531993f4ecb7e007234179 /lib | |
| parent | 2727c43f8dcef9f6a0c3c117e30d00de145bde11 (diff) | |
| download | opensbi-4dc1b9f7baac61cb49e9f6b58ebea73cbd663500.tar.gz opensbi-4dc1b9f7baac61cb49e9f6b58ebea73cbd663500.tar.bz2 opensbi-4dc1b9f7baac61cb49e9f6b58ebea73cbd663500.zip | |
lib: fdt_helper: Removed unnecessary dt parsing check
The check for the address being different from 0 for the UART, PLIC,
APLIC and IMSIC dt nodes is unnnecessary and could skip valid nodes.
Signed-off-by: Victoriano Morales <victoriano.morales@openchip.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260219083423.30690-1-victoriano.morales@openchip.com
Signed-off-by: Anup Patel <anup@brainfault.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/utils/fdt/fdt_helper.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c index 799fd48d..a8c6e1aa 100644 --- a/lib/utils/fdt/fdt_helper.c +++ b/lib/utils/fdt/fdt_helper.c @@ -502,7 +502,7 @@ static int fdt_parse_uart_node_common(const void *fdt, int nodeoffset, rc = fdt_get_node_addr_size(fdt, nodeoffset, 0, ®_addr, ®_size); - if (rc < 0 || !reg_addr || !reg_size) + if (rc < 0 || !reg_size) return SBI_ENODEV; uart->addr = reg_addr; @@ -671,7 +671,7 @@ int fdt_parse_aplic_node(const void *fdt, int nodeoff, struct aplic_data *aplic) return SBI_ENODEV; rc = fdt_get_node_addr_size(fdt, nodeoff, 0, ®_addr, ®_size); - if (rc < 0 || !reg_addr || !reg_size) + if (rc < 0 || !reg_size) return SBI_ENODEV; aplic->addr = reg_addr; aplic->size = reg_size; @@ -863,7 +863,7 @@ int fdt_parse_imsic_node(const void *fdt, int nodeoff, struct imsic_data *imsic) rc = fdt_get_node_addr_size(fdt, nodeoff, i, ®_addr, ®_size); - if (rc < 0 || !reg_addr || !reg_size) + if (rc < 0 || !reg_size) break; regs->addr = reg_addr; regs->size = reg_size; @@ -885,7 +885,7 @@ int fdt_parse_plic_node(const void *fdt, int nodeoffset, struct plic_data *plic) rc = fdt_get_node_addr_size(fdt, nodeoffset, 0, ®_addr, ®_size); - if (rc < 0 || !reg_addr || !reg_size) + if (rc < 0 || !reg_size) return SBI_ENODEV; plic->addr = reg_addr; plic->size = reg_size; |