aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClément Léger <cleger@rivosinc.com>2025-02-13 10:25:03 +0100
committerAnup Patel <anup@brainfault.org>2025-02-19 17:18:13 +0530
commitf354400ebf91f2988a20da52a6399ac51988fc95 (patch)
tree38536f1d22a1d99e8dae4ff7c39dec0f4bf6c21b
parent1f64fef919fc5739df6c3395a9abd256dc88cb24 (diff)
downloadopensbi-f354400ebf91f2988a20da52a6399ac51988fc95.zip
opensbi-f354400ebf91f2988a20da52a6399ac51988fc95.tar.gz
opensbi-f354400ebf91f2988a20da52a6399ac51988fc95.tar.bz2
lib: sbi: sse: fix invalid errors returned for sse_hart_mask/unmask()
When called twice, sse_hart_mask()/sse_hart_unmask() should return SBI_EALREADY_STOPPED/SBI_EALREADY_STARTED. This was currently inverted. Fixes: b919daf49582 ("lib: sbi: Add support to mask/unmask SSE events") Reported-by: Andrew Jones <ajones@ventanamicro.com> Signed-off-by: Clément Léger <cleger@rivosinc.com> Reviewed-by: Samuel Holland <samuel.holland@sifive.com> Reviewed-by: Anup Patel <anup@brainfault.org>
-rw-r--r--lib/sbi/sbi_sse.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c
index 9f22375..2f9bdef 100644
--- a/lib/sbi/sbi_sse.c
+++ b/lib/sbi/sbi_sse.c
@@ -882,7 +882,7 @@ int sbi_sse_hart_mask(void)
return SBI_EFAIL;
if (state->masked)
- return SBI_EALREADY_STARTED;
+ return SBI_EALREADY_STOPPED;
state->masked = true;
@@ -897,7 +897,7 @@ int sbi_sse_hart_unmask(void)
return SBI_EFAIL;
if (!state->masked)
- return SBI_EALREADY_STOPPED;
+ return SBI_EALREADY_STARTED;
state->masked = false;