diff options
| author | Xiang W <wxjstz@126.com> | 2025-03-19 20:39:38 +0800 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2025-04-15 11:38:20 +0530 |
| commit | 190979b4fce6ded989338a0943feeb035db7b75a (patch) | |
| tree | 7c0c4e9f24d8ece1dbed1a83a8497c0b8543a0f7 | |
| parent | 169b4b8ae2f3f1b337179a176a299284d0bed4fe (diff) | |
| download | opensbi-190979b4fce6ded989338a0943feeb035db7b75a.zip opensbi-190979b4fce6ded989338a0943feeb035db7b75a.tar.gz opensbi-190979b4fce6ded989338a0943feeb035db7b75a.tar.bz2 | |
lib: sbi: Remove unnecessary SBI_INIT_LIST_HEAD
No need to initialise the nodes to be added to the linked list
Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20250319123944.505756-1-wxjstz@126.com
Signed-off-by: Anup Patel <anup@brainfault.org>
| -rw-r--r-- | lib/sbi/sbi_ecall.c | 1 | ||||
| -rw-r--r-- | lib/sbi/sbi_heap.c | 1 | ||||
| -rw-r--r-- | lib/sbi/sbi_mpxy.c | 1 | ||||
| -rw-r--r-- | lib/utils/fdt/fdt_fixup.c | 1 | ||||
| -rw-r--r-- | lib/utils/mailbox/mailbox.c | 2 |
5 files changed, 0 insertions, 6 deletions
diff --git a/lib/sbi/sbi_ecall.c b/lib/sbi/sbi_ecall.c index 3fa3a9e..745fa31 100644 --- a/lib/sbi/sbi_ecall.c +++ b/lib/sbi/sbi_ecall.c @@ -93,7 +93,6 @@ int sbi_ecall_register_extension(struct sbi_ecall_extension *ext) return SBI_EINVAL; } - SBI_INIT_LIST_HEAD(&ext->head); sbi_list_add_tail(&ext->head, &ecall_exts_list); return 0; diff --git a/lib/sbi/sbi_heap.c b/lib/sbi/sbi_heap.c index 6d08e44..646c2e0 100644 --- a/lib/sbi/sbi_heap.c +++ b/lib/sbi/sbi_heap.c @@ -244,7 +244,6 @@ int sbi_heap_init_new(struct sbi_heap_control *hpctrl, unsigned long base, /* Prepare free node list */ for (i = 0; i < (hpctrl->hksize / sizeof(*n)); i++) { n = (struct heap_node *)(hpctrl->hkbase + (sizeof(*n) * i)); - SBI_INIT_LIST_HEAD(&n->head); n->addr = n->size = 0; sbi_list_add_tail(&n->head, &hpctrl->free_node_list); } diff --git a/lib/sbi/sbi_mpxy.c b/lib/sbi/sbi_mpxy.c index 920d2db..d138596 100644 --- a/lib/sbi/sbi_mpxy.c +++ b/lib/sbi/sbi_mpxy.c @@ -228,7 +228,6 @@ int sbi_mpxy_register_channel(struct sbi_mpxy_channel *channel) mpxy_shmem_size = (mpxy_shmem_size + (PAGE_SIZE - 1)) / PAGE_SIZE; } - SBI_INIT_LIST_HEAD(&channel->head); sbi_list_add_tail(&channel->head, &mpxy_channel_list); return SBI_OK; diff --git a/lib/utils/fdt/fdt_fixup.c b/lib/utils/fdt/fdt_fixup.c index 192d6dd..e237dd0 100644 --- a/lib/utils/fdt/fdt_fixup.c +++ b/lib/utils/fdt/fdt_fixup.c @@ -415,7 +415,6 @@ int fdt_register_general_fixup(struct fdt_general_fixup *fixup) return SBI_EALREADY; } - SBI_INIT_LIST_HEAD(&fixup->head); sbi_list_add_tail(&fixup->head, &fixup_list); return 0; diff --git a/lib/utils/mailbox/mailbox.c b/lib/utils/mailbox/mailbox.c index 2ea7a00..b3f7e8b 100644 --- a/lib/utils/mailbox/mailbox.c +++ b/lib/utils/mailbox/mailbox.c @@ -34,7 +34,6 @@ int mbox_controller_add(struct mbox_controller *mbox) if (mbox_controller_find(mbox->id)) return SBI_EALREADY; - SBI_INIT_LIST_HEAD(&mbox->node); ATOMIC_INIT(&mbox->xfer_next_seq, 0); SBI_INIT_LIST_HEAD(&mbox->chan_list); sbi_list_add(&mbox->node, &mbox_list); @@ -80,7 +79,6 @@ struct mbox_chan *mbox_controller_request_chan(struct mbox_controller *mbox, if (!ret) return NULL; - SBI_INIT_LIST_HEAD(&ret->node); ret->mbox = mbox; sbi_memcpy(ret->chan_args, chan_args, sizeof(ret->chan_args)); sbi_list_add(&ret->node, &mbox->chan_list); |