lcitool: Drop the 'build' command

Although this used to be useful back in the day when most of our listed
projects (mostly libvirt though) were built in VMs, with the rise of
git forge like services providing containers to build projects from
sources this feature is became less useful. Although having become
obsolete, the biggest problems of this feature were that:

- the extra Ansible layer in form of playbooks abstracted useful bits
  like real-time stdout logging of the build process making debugging
  of a build issue more difficult than if having it done manually,
  especially considering the JSON serialized stderr dump it returns

- project dependencies - in order to built project X, project Y had
  likely to be built prior to project X so that fresh builddeps were
  available at project X's build time. Not only the projects had to be
  named in the exact order they were to be built, but project Y could
  not even specify that it could be built against distro provided
  builddeps if so desired.

- slight changes to the build procedure or tool chains used in the
  respective upstream projects.

Should a build happen in such a VM, each and every project is
responsible to maintain their own build recipes which the user can
happily execute interactively inside an lcitool-prepared VM.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

2 files changed, 0 insertions, 31 deletions

diff --git a/lcitool/application.py b/lcitool/application.py
index 9104ce4..c84da63 100644
--- a/lcitool/application.py
+++ b/lcitool/application.py
@@ -206,20 +206,6 @@ class Application:
         self._execute_playbook("update", args.hosts, args.projects,
                                None, args.data_dir, args.verbose)
 
-    def _action_build(self, args):
-        self._entrypoint_debug(args)
-
-        # we don't keep a dependencies tree for projects, hence pattern
-        # expansion would break the 'build' playbook
-        if args.projects == "all" or "*" in args.projects:
-            raise ApplicationError(
-                "'build' command doesn't support specifying projects by "
-                "either wildcards or the 'all' keyword"
-            )
-
-        self._execute_playbook("build", args.hosts, args.projects,
-                               args.git_revision, args.data_dir, args.verbose)
-
     def _action_variables(self, args):
         self._entrypoint_debug(args)
 
diff --git a/lcitool/commandline.py b/lcitool/commandline.py
index 7b5649c..81c1e66 100644
--- a/lcitool/commandline.py
+++ b/lcitool/commandline.py
@@ -111,12 +111,6 @@ class CommandLine:
             help="list of projects to consider (accepts globs)",
         )
 
-        gitrevopt = argparse.ArgumentParser(add_help=False)
-        gitrevopt.add_argument(
-            "-g", "--git-revision",
-            help="git revision to build (remote/branch)",
-        )
-
         containerizedopt = argparse.ArgumentParser(add_help=False)
         containerizedopt.add_argument(
             "-c", "--containerized",
@@ -239,17 +233,6 @@ class CommandLine:
         )
         updateparser.set_defaults(func=Application._action_update)
 
-        buildparser = subparsers.add_parser(
-            "build",
-            help="build projects on hosts",
-            parents=[verbosityopt, hostsopt, gitrevopt],
-        )
-        buildparser.add_argument(
-            "projects",
-            help="list of projects to consider (does NOT accept globs)",
-        )
-        buildparser.set_defaults(func=Application._action_build)
-
         hostsparser = subparsers.add_parser(
             "hosts",
             help="list all known hosts",