diff options
| author | Erik Skultety <eskultet@redhat.com> | 2022-05-31 15:07:48 +0200 |
|---|---|---|
| committer | Andrea Bolognani <eof@kiyuko.org> | 2022-06-01 11:57:50 +0000 |
| commit | 0ac812d80e5766a66485022eafeaf9c9de47c27b (patch) | |
| tree | 011e8194ff88f91042de4658affd02cd1c04997c | |
| parent | 9818172f9f1f72330cfc8637aa463523ef6e58ca (diff) | |
| download | libvirt-ci-0ac812d80e5766a66485022eafeaf9c9de47c27b.zip libvirt-ci-0ac812d80e5766a66485022eafeaf9c9de47c27b.tar.gz libvirt-ci-0ac812d80e5766a66485022eafeaf9c9de47c27b.tar.bz2 | |
guests: Application: Use the now mandatory --osinfo virt-install option
Since virt-install-4.0.0 (Fedora 36) the '--osinfo' option is now
required and if missing the execution fails with:
ERROR
--os-variant/--osinfo OS name is required, but no value was
set or detected.
This is now a fatal error. Specifying an OS name is required
for modern, performant, and secure virtual machine defaults.
Since lcitool VM's are rather single purpose we don't really miss out
on much by not selecting a specific OS variant with virt-install.
After all, this project and osinfodb introduce OS support at different
pace and we'd be locking ourselves by waiting for the host distro to
release an updated version of osinfodb (if ever on older host OSes)
just to get support for a platform we want to test on.
Therefore, the easiest fix for the option is to pass the 'unknown'
OS target to virt-install.
Signed-off-by: Erik Skultety <eskultet@redhat.com>
| -rw-r--r-- | guests/lcitool/lcitool/application.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/guests/lcitool/lcitool/application.py b/guests/lcitool/lcitool/application.py index eb2e7fd..4f555a2 100644 --- a/guests/lcitool/lcitool/application.py +++ b/guests/lcitool/lcitool/application.py @@ -275,6 +275,7 @@ class Application(metaclass=Singleton): cmd = [ "virt-install", + "--osinfo", "unknown", "--name", host, "--location", facts["install"]["url"], "--virt-type", config.values["install"]["virt_type"], |