General fixes (#213)

* Reorg vfu_create_ctx() 
* Unconditionally call dma_controller_create() in vfu_setup_device_dma_cb().
* Added UT for vfu_setup_device_dma_cb()


Signed-off-by: Swapnil Ingle <swapnil.ingle@nutanix.com>
Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>

1 files changed, 11 insertions, 1 deletions

diff --git a/test/unit-tests.c b/test/unit-tests.c
index 59b24dc..6355843 100644
--- a/test/unit-tests.c
+++ b/test/unit-tests.c
@@ -680,6 +680,15 @@ test_dma_map_sg(void **state __attribute__((unused)))
 
 }
 
+static void
+test_vfu_setup_device_dma_cb(void **state __attribute__((unused)))
+{
+    vfu_ctx_t vfu_ctx = { 0 };
+
+    assert_int_equal(0, vfu_setup_device_dma_cb(&vfu_ctx, NULL, NULL));
+    assert_non_null(vfu_ctx.dma);
+}
+
 /*
  * FIXME we shouldn't have to specify a setup function explicitly for each unit
  * test, cmocka should provide that. E.g. cmocka_run_group_tests enables us to
@@ -712,7 +721,8 @@ int main(void)
         cmocka_unit_test_setup(test_get_region_info, setup),
         cmocka_unit_test_setup(test_setup_sparse_region, setup),
         cmocka_unit_test_setup(test_dma_map_return_value, setup),
-        cmocka_unit_test_setup(test_dma_map_sg, setup)
+        cmocka_unit_test_setup(test_dma_map_sg, setup),
+        cmocka_unit_test_setup(test_vfu_setup_device_dma_cb, setup)
     };
 
     return cmocka_run_group_tests(tests, NULL, NULL);