correct PM capability definition (#452)

the static size assert for the PMCS register was checking the wrong struct;
however, the struct was nonetheless 4 bytes long, due to uint bitfields. This
accidentally meant the containing struct pmcap was the correct size (the
alignment attribute makes no difference).

After fixing struct pmcs, we'll include the additional two bytes defined in the
PCI PM specification, Section 3.2. These are "optional", but as elsewhere, we'll
require them when adding the capability.

Signed-off-by: John Levon <john.levon@nutanix.com>
Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>

1 files changed, 14 insertions, 1 deletions

diff --git a/lib/pci_caps.c b/lib/pci_caps.c
index 50b1ec3..8ed5643 100644
--- a/lib/pci_caps.c
+++ b/lib/pci_caps.c
@@ -141,7 +141,7 @@ cap_write_pm(vfu_ctx_t *vfu_ctx, struct pci_cap *cap, char * buf,
         if (count != sizeof(struct pc)) {
             return ERROR_INT(EINVAL);
         }
-        vfu_log(vfu_ctx, LOG_ERR, "FIXME: write to pmcp::pc unimplemented");
+        vfu_log(vfu_ctx, LOG_ERR, "FIXME: write to pmcap::pc unimplemented");
         return ERROR_INT(ENOTSUP);
     case offsetof(struct pmcap, pmcs):
         if (count != sizeof(struct pmcs)) {
@@ -149,6 +149,19 @@ cap_write_pm(vfu_ctx_t *vfu_ctx, struct pci_cap *cap, char * buf,
         }
         handle_pmcs_write(vfu_ctx, pm, (struct pmcs *)buf);
         return sizeof(struct pmcs);
+    case offsetof(struct pmcap, pmcsr_bse):
+        if (count != 1) {
+            return ERROR_INT(EINVAL);
+        }
+        vfu_log(vfu_ctx, LOG_ERR,
+                "FIXME: write to pmcap::pmcsr_bse unimplemented");
+        return ERROR_INT(ENOTSUP);
+    case offsetof(struct pmcap, data):
+        if (count != 1) {
+            return ERROR_INT(EINVAL);
+        }
+        vfu_log(vfu_ctx, LOG_ERR, "FIXME: write to pmcap::data unimplemented");
+        return ERROR_INT(ENOTSUP);
     }
     return ERROR_INT(EINVAL);
 }