aboutsummaryrefslogtreecommitdiff
path: root/platforms
diff options
context:
space:
mode:
authorNicholas Piggin <npiggin@gmail.com>2019-12-08 22:23:11 +1000
committerOliver O'Halloran <oohall@gmail.com>2019-12-16 14:50:56 +1100
commite04a34af200a31a29d83162a46dedbeb59ae917e (patch)
tree8af57c0447671bc273c0ffc792e09161163e4008 /platforms
parent5178691d0ad8d684f061d596dc6e025823fc0fec (diff)
downloadskiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.zip
skiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.tar.gz
skiboot-e04a34af200a31a29d83162a46dedbeb59ae917e.tar.bz2
fix simple sparse warnings
Should be no real code change, these mostly update type declarations that sparse complains about. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'platforms')
-rw-r--r--platforms/astbmc/common.c4
-rw-r--r--platforms/astbmc/p8dtu.c2
-rw-r--r--platforms/astbmc/p9dsu.c2
-rw-r--r--platforms/astbmc/witherspoon.c6
4 files changed, 7 insertions, 7 deletions
diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c
index 15ac231..de837f3 100644
--- a/platforms/astbmc/common.c
+++ b/platforms/astbmc/common.c
@@ -503,13 +503,13 @@ void astbmc_exit(void)
ipmi_wdt_final_reset();
}
-const struct bmc_sw_config bmc_sw_ami = {
+static const struct bmc_sw_config bmc_sw_ami = {
.ipmi_oem_partial_add_esel = IPMI_CODE(0x3a, 0xf0),
.ipmi_oem_pnor_access_status = IPMI_CODE(0x3a, 0x07),
.ipmi_oem_hiomap_cmd = IPMI_CODE(0x3a, 0x5a),
};
-const struct bmc_sw_config bmc_sw_openbmc = {
+static const struct bmc_sw_config bmc_sw_openbmc = {
.ipmi_oem_partial_add_esel = IPMI_CODE(0x3a, 0xf0),
.ipmi_oem_hiomap_cmd = IPMI_CODE(0x3a, 0x5a),
};
diff --git a/platforms/astbmc/p8dtu.c b/platforms/astbmc/p8dtu.c
index c62223b..a9d8dc0 100644
--- a/platforms/astbmc/p8dtu.c
+++ b/platforms/astbmc/p8dtu.c
@@ -223,7 +223,7 @@ static const struct bmc_sw_config bmc_sw_smc = {
};
/* Provided by Eric Chen (SMC) */
-const struct bmc_hw_config p8dtu_bmc_hw = {
+static const struct bmc_hw_config p8dtu_bmc_hw = {
.scu_revision_id = 0x02010303,
.mcr_configuration = 0x00000577,
.mcr_scu_mpll = 0x000050c0,
diff --git a/platforms/astbmc/p9dsu.c b/platforms/astbmc/p9dsu.c
index d49f7fe..5c9756e 100644
--- a/platforms/astbmc/p9dsu.c
+++ b/platforms/astbmc/p9dsu.c
@@ -695,7 +695,7 @@ static const struct bmc_sw_config bmc_sw_smc = {
};
/* Provided by Eric Chen (SMC) */
-const struct bmc_hw_config p9dsu_bmc_hw = {
+static const struct bmc_hw_config p9dsu_bmc_hw = {
.scu_revision_id = 0x04030303,
.mcr_configuration = 0x11000756,
.mcr_scu_mpll = 0x000071c1,
diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c
index c576a17..0819966 100644
--- a/platforms/astbmc/witherspoon.c
+++ b/platforms/astbmc/witherspoon.c
@@ -325,7 +325,7 @@ i2c_failed:
return;
}
-const struct platform_ocapi witherspoon_ocapi = {
+static const struct platform_ocapi witherspoon_ocapi = {
.i2c_engine = 1,
.i2c_port = 4,
.odl_phy_swap = false,
@@ -370,8 +370,8 @@ static int gpu_slot_to_num(const char *slot)
static void npu2_phb_nvlink_dt(struct phb *npuphb)
{
- struct dt_node *g[3] = { 0 }; /* Current maximum is 3 GPUs per 1 NPU */
- struct dt_node *n[6] = { 0 };
+ struct dt_node *g[3] = { NULL }; /* Current maximum 3 GPUs per 1 NPU */
+ struct dt_node *n[6] = { NULL };
int max_gpus, i, gpuid, first, last;
struct npu2 *npu2_phb = phb_to_npu2_nvlink(npuphb);
struct pci_device *npd;