diff options
| author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-21 11:55:12 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-21 12:25:28 +1000 |
| commit | d4d436cb6ea24efb3461340fd5c2ee5b486c6b8a (patch) | |
| tree | 3fab57d16c191d0d77c4bb98381e51d552897a58 /platforms | |
| parent | b1a4e606feb4d904a1e29884a1d55f0f89bd46c8 (diff) | |
| download | skiboot-d4d436cb6ea24efb3461340fd5c2ee5b486c6b8a.zip skiboot-d4d436cb6ea24efb3461340fd5c2ee5b486c6b8a.tar.gz skiboot-d4d436cb6ea24efb3461340fd5c2ee5b486c6b8a.tar.bz2 | |
ibm-fsp/firenze: Fix unused overwritten value
Found with static analysis:
939 id = ((uint64_t)p[1] << 32) | p[2];
value_overwrite: Overwriting previous write to id with value 0ULL.
940 id = 0;
Fixes: 6884fe63
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'platforms')
| -rw-r--r-- | platforms/ibm-fsp/firenze-pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/platforms/ibm-fsp/firenze-pci.c b/platforms/ibm-fsp/firenze-pci.c index b13f1e5..4a9aff3 100644 --- a/platforms/ibm-fsp/firenze-pci.c +++ b/platforms/ibm-fsp/firenze-pci.c @@ -937,7 +937,7 @@ static void firenze_pci_slot_fixup(struct pci_slot *slot) /* FIXME: support fixup with generic way */ id = ((uint64_t)p[1] << 32) | p[2]; - id = 0; + if (id != LX_VPD_2S4U_BACKPLANE && id != LX_VPD_1S4U_BACKPLANE) return; |