aboutsummaryrefslogtreecommitdiff
path: root/platforms
diff options
context:
space:
mode:
authorOliver O'Halloran <oohall@gmail.com>2020-03-05 17:52:00 +1100
committerOliver O'Halloran <oohall@gmail.com>2020-03-11 17:24:16 +1100
commitb776bb0fa86b31873007c7e4f677dfb7a70e54d2 (patch)
treefafe6b2a357047bc10a99e0217d4048edaa582d2 /platforms
parent2e122fbadf7f1175202151f72ee4b81bcb811cb3 (diff)
downloadskiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.zip
skiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.tar.gz
skiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.tar.bz2
hw/fsp: Fix GENERIC_FAILURE mailbox status code
The 0xEF return code is used to tell the hypervisor that the FSP was not able to replicate an NVRAM write to the secondary FSP. The GENERIC_FAILURE is using this code instead of the correct 0xFE code which indicates a generic error condition. We already have a FSP_STATUS_GENERIC_ERROR for 0xFE so convert the existing users of FSP_STATUS_GENERIC_FAILURE to use GENERIC_ERROR and remove the duplicate. Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'platforms')
-rw-r--r--platforms/ibm-fsp/hostservices.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/platforms/ibm-fsp/hostservices.c b/platforms/ibm-fsp/hostservices.c
index d93c4f6..d61d583 100644
--- a/platforms/ibm-fsp/hostservices.c
+++ b/platforms/ibm-fsp/hostservices.c
@@ -883,7 +883,7 @@ static bool hservice_hbrt_msg_notify(uint32_t cmd_sub_mod, struct fsp_msg *msg)
}
if (prd_hbrt_fsp_msg_notify(buf, len)) {
- hservice_hbrt_msg_response(FSP_STATUS_GENERIC_FAILURE);
+ hservice_hbrt_msg_response(FSP_STATUS_GENERIC_ERROR);
prlog(PR_NOTICE, "Unable to send FSP - HBRT message\n");
}