diff options
| author | Michael Neuling <mikey@neuling.org> | 2017-12-06 11:12:33 +1100 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2017-12-14 23:58:38 -0600 |
| commit | 852ff7e210b29c8b96450d5aa02c00542041a451 (patch) | |
| tree | 32c59d03e09a68e09e41542d7c951e468d12c3ed /hw | |
| parent | 0f9a776aa72f75b1983c9d6cd4dd8bf7bef0883a (diff) | |
| download | skiboot-852ff7e210b29c8b96450d5aa02c00542041a451.zip skiboot-852ff7e210b29c8b96450d5aa02c00542041a451.tar.gz skiboot-852ff7e210b29c8b96450d5aa02c00542041a451.tar.bz2 | |
IPMI: Fix platform.cec_reboot() null ptr checks
Kudos to Hugo Landau who reported this in:
https://github.com/open-power/skiboot/issues/142
Reported-by: Hugo Landau <hlandau@devever.net>
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw')
| -rw-r--r-- | hw/ipmi/ipmi-attn.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/ipmi/ipmi-attn.c b/hw/ipmi/ipmi-attn.c index ef7153e..8ff872c 100644 --- a/hw/ipmi/ipmi-attn.c +++ b/hw/ipmi/ipmi-attn.c @@ -67,7 +67,7 @@ void __attribute__((noreturn)) ipmi_terminate(const char *msg) { /* Terminate called before initializing IPMI (early abort) */ if (!ipmi_present()) { - if (platform.cec_reboot()) + if (platform.cec_reboot) platform.cec_reboot(); goto out; } @@ -76,7 +76,7 @@ void __attribute__((noreturn)) ipmi_terminate(const char *msg) ipmi_log_terminate_event(msg); /* Reboot call */ - if (platform.cec_reboot()) + if (platform.cec_reboot) platform.cec_reboot(); out: |