diff options
author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-08-31 18:06:18 +1000 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-09-01 14:11:23 +1000 |
commit | 591eb07e4f40044034de26179f0567f7529ff7fa (patch) | |
tree | 180166771295d0f4e8ab2787226dadae27ee97d4 /hw | |
parent | 13c603d6a14ba06027a9b178c9d26b3e691b45c2 (diff) | |
download | skiboot-591eb07e4f40044034de26179f0567f7529ff7fa.zip skiboot-591eb07e4f40044034de26179f0567f7529ff7fa.tar.gz skiboot-591eb07e4f40044034de26179f0567f7529ff7fa.tar.bz2 |
Fix scan-build warning of value stored to event is never used
In send_pending_events() we set event to the type of event received
yet did nothing with it.
This seems to be a left over bit of code, as what does happen is on
consuming the message (prd_msg_consumed) we'll clear the event bit
and then send the next event:
120 if (event)
121 events[proc] &= ~event;
122 prd_msg_inuse = false;
123 send_pending_events();
124 unlock(&events_lock);
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Acked-by: Jeremy Kerr <jk@ozlabs.org>
Diffstat (limited to 'hw')
-rw-r--r-- | hw/prd.c | 6 |
1 files changed, 0 insertions, 6 deletions
@@ -176,18 +176,12 @@ static void send_pending_events(void) if (event & EVENT_ATTN) { prd_msg.hdr.type = OPAL_PRD_MSG_TYPE_ATTN; populate_ipoll_msg(&prd_msg, proc); - event = EVENT_ATTN; - } else if (event & EVENT_OCC_ERROR) { prd_msg.hdr.type = OPAL_PRD_MSG_TYPE_OCC_ERROR; prd_msg.occ_error.chip = proc; - event = EVENT_OCC_ERROR; - } else if (event & EVENT_OCC_RESET) { prd_msg.hdr.type = OPAL_PRD_MSG_TYPE_OCC_RESET; prd_msg.occ_reset.chip = proc; - event = EVENT_OCC_RESET; - } queue_prd_msg(&prd_msg, prd_msg_consumed); |