aboutsummaryrefslogtreecommitdiff
path: root/hw
diff options
context:
space:
mode:
authorOliver O'Halloran <oohall@gmail.com>2020-03-05 16:12:38 +1100
committerOliver O'Halloran <oohall@gmail.com>2020-03-11 17:23:57 +1100
commit2e122fbadf7f1175202151f72ee4b81bcb811cb3 (patch)
tree75b471a1a1157588200bbeba15a0b2433a083a32 /hw
parentdaf9215c85f910043c472984683948baaf18da39 (diff)
downloadskiboot-2e122fbadf7f1175202151f72ee4b81bcb811cb3.zip
skiboot-2e122fbadf7f1175202151f72ee4b81bcb811cb3.tar.gz
skiboot-2e122fbadf7f1175202151f72ee4b81bcb811cb3.tar.bz2
hw/fsp: Remove stray va_end() in __fsp_fillmsg()
__fsp_fillmsg() is called from fsp_fillmsg() and fsp_mkmsg(). Both callers wrap it in a va_start() / va_end() pair so using va_end() inside the function is almost certainly wrong. Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'hw')
-rw-r--r--hw/fsp/fsp.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/fsp/fsp.c b/hw/fsp/fsp.c
index 196fa34..392cf5d 100644
--- a/hw/fsp/fsp.c
+++ b/hw/fsp/fsp.c
@@ -995,7 +995,6 @@ static void __fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod,
for (i = 0; i < add_words; i++)
fsp_msg_set_data_word(msg, i, va_arg(list, unsigned int));
- va_end(list);
}
void fsp_fillmsg(struct fsp_msg *msg, u32 cmd_sub_mod, u32 add_words, ...)