diff options
| author | Oliver O'Halloran <oohall@gmail.com> | 2020-03-05 17:52:00 +1100 |
|---|---|---|
| committer | Oliver O'Halloran <oohall@gmail.com> | 2020-03-11 17:24:16 +1100 |
| commit | b776bb0fa86b31873007c7e4f677dfb7a70e54d2 (patch) | |
| tree | fafe6b2a357047bc10a99e0217d4048edaa582d2 /hw/prd.c | |
| parent | 2e122fbadf7f1175202151f72ee4b81bcb811cb3 (diff) | |
| download | skiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.zip skiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.tar.gz skiboot-b776bb0fa86b31873007c7e4f677dfb7a70e54d2.tar.bz2 | |
hw/fsp: Fix GENERIC_FAILURE mailbox status code
The 0xEF return code is used to tell the hypervisor that the FSP was not
able to replicate an NVRAM write to the secondary FSP. The GENERIC_FAILURE
is using this code instead of the correct 0xFE code which indicates a
generic error condition.
We already have a FSP_STATUS_GENERIC_ERROR for 0xFE so convert the
existing users of FSP_STATUS_GENERIC_FAILURE to use GENERIC_ERROR
and remove the duplicate.
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Diffstat (limited to 'hw/prd.c')
| -rw-r--r-- | hw/prd.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -119,7 +119,7 @@ static void prd_msg_consumed(void *data, int status) if (status != 0) { prlog(PR_DEBUG, "PRD: Failed to send FSP -> HBRT message\n"); - notify_status = FSP_STATUS_GENERIC_FAILURE; + notify_status = FSP_STATUS_GENERIC_ERROR; } assert(platform.prd); assert(platform.prd->msg_response); @@ -372,7 +372,7 @@ int prd_hbrt_fsp_msg_notify(void *data, u32 dsize) { struct prd_fw_msg *fw_notify; int size, fw_notify_size; - int rc = FSP_STATUS_GENERIC_FAILURE; + int rc = FSP_STATUS_GENERIC_ERROR; if (!prd_enabled || !prd_active) { prlog(PR_NOTICE, "PRD: %s: PRD daemon is not ready\n", |