diff options
author | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 15:46:34 +1000 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-24 15:50:13 +1000 |
commit | d39a3ad0b0c14be3eba563371371fe9035ba8748 (patch) | |
tree | 686f6440449a25f957205fd672d0a3841a368a44 /hw/fsp | |
parent | b0b2c64e1c31a737019950219685bba4edbbd95f (diff) | |
download | skiboot-d39a3ad0b0c14be3eba563371371fe9035ba8748.zip skiboot-d39a3ad0b0c14be3eba563371371fe9035ba8748.tar.gz skiboot-d39a3ad0b0c14be3eba563371371fe9035ba8748.tar.bz2 |
fsp-surveillance: add FWTS annotation on failing to reply to heartbeat
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp')
-rw-r--r-- | hw/fsp/fsp-surveillance.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c index 24acead..d3e5c45 100644 --- a/hw/fsp/fsp-surveillance.c +++ b/hw/fsp/fsp-surveillance.c @@ -58,9 +58,16 @@ static void fsp_surv_ack(struct fsp_msg *msg) lock(&surv_lock); fsp_surv_ack_pending = false; unlock(&surv_lock); - } else + } else { + /** + * @fwts-label FSPHeartbeatAckError + * @fwts-advice Error in acknowledging heartbeat to FSP. + * This could mean the FSP has gone away or it may mean + * the FSP may kill us for missing too many heartbeats. + */ prlog(PR_ERR, "SURV: Heartbeat Acknowledgment error from FSP\n"); + } fsp_freemsg(msg); } |