From d39a3ad0b0c14be3eba563371371fe9035ba8748 Mon Sep 17 00:00:00 2001 From: Stewart Smith Date: Fri, 24 Jun 2016 15:46:34 +1000 Subject: fsp-surveillance: add FWTS annotation on failing to reply to heartbeat Signed-off-by: Stewart Smith --- hw/fsp/fsp-surveillance.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'hw/fsp') diff --git a/hw/fsp/fsp-surveillance.c b/hw/fsp/fsp-surveillance.c index 24acead..d3e5c45 100644 --- a/hw/fsp/fsp-surveillance.c +++ b/hw/fsp/fsp-surveillance.c @@ -58,9 +58,16 @@ static void fsp_surv_ack(struct fsp_msg *msg) lock(&surv_lock); fsp_surv_ack_pending = false; unlock(&surv_lock); - } else + } else { + /** + * @fwts-label FSPHeartbeatAckError + * @fwts-advice Error in acknowledging heartbeat to FSP. + * This could mean the FSP has gone away or it may mean + * the FSP may kill us for missing too many heartbeats. + */ prlog(PR_ERR, "SURV: Heartbeat Acknowledgment error from FSP\n"); + } fsp_freemsg(msg); } -- cgit v1.1