diff options
| author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2015-07-10 15:25:36 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-07-17 12:02:41 +1000 |
| commit | 3aca615306e00a2abef7bd45dba2e7046085243a (patch) | |
| tree | 184506a5610643c4e80cf9dc2a68ecc50728d7cf /hdata | |
| parent | cd0d009183b0a0ce2e048c90d9f94ab06f297b1d (diff) | |
| download | skiboot-3aca615306e00a2abef7bd45dba2e7046085243a.zip skiboot-3aca615306e00a2abef7bd45dba2e7046085243a.tar.gz skiboot-3aca615306e00a2abef7bd45dba2e7046085243a.tar.bz2 | |
hdata/paca: Check for dt_find_property() return value
dt_find_property() might return NULL. In __paca_parse(),
check for return value, before dereferencing it.
Also fix trailing white spaces.
Fixes Coverity defect#97842.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hdata')
| -rw-r--r-- | hdata/paca.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/hdata/paca.c b/hdata/paca.c index b0e6426..4f2006a 100644 --- a/hdata/paca.c +++ b/hdata/paca.c @@ -207,7 +207,7 @@ static bool __paca_parse(void) paca = get_hdif(&spira.ntuples.paca, PACA_HDIF_SIG); if (!paca) { - prerror("Invalid PACA (PCIA = %p)\n", + prerror("Invalid PACA (PCIA = %p)\n", ntuple_addr(&spira.ntuples.pcia)); return false; } @@ -299,6 +299,11 @@ static bool __paca_parse(void) /* Add the cpu #. */ prop = dt_find_property(cpu, "ibm,ppc-interrupt-server#s"); + if (!prop) { + prerror("CPU[%i]: could not find mapping information\n", + paca_index(paca)); + return false; + } num = prop->len / sizeof(u32); new_prop = malloc((num + 1) * sizeof(u32)); if (!new_prop) { @@ -317,7 +322,7 @@ static bool __paca_parse(void) add_icps(); return true; -} +} void paca_parse(void) { |