aboutsummaryrefslogtreecommitdiff
path: root/hdata/memory.c
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2014-12-05 14:20:37 +1100
committerStewart Smith <stewart@linux.vnet.ibm.com>2014-12-05 14:20:37 +1100
commitf1a3a19d723524659bc91c8f65f3ed769a612c9b (patch)
tree8eb0b170d103412b5bf3a1f0f9c54fa3ca753cb7 /hdata/memory.c
parent1ecb55c3a8f955a62ef3b1e30baca642d52dbfd5 (diff)
downloadskiboot-f1a3a19d723524659bc91c8f65f3ed769a612c9b.zip
skiboot-f1a3a19d723524659bc91c8f65f3ed769a612c9b.tar.gz
skiboot-f1a3a19d723524659bc91c8f65f3ed769a612c9b.tar.bz2
Fix warning of potential unbound stack usage in hdata/memory.c
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hdata/memory.c')
-rw-r--r--hdata/memory.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/hdata/memory.c b/hdata/memory.c
index d6e87cb..cf336a0 100644
--- a/hdata/memory.c
+++ b/hdata/memory.c
@@ -116,9 +116,11 @@ static bool add_address_range(struct dt_node *root,
{
struct dt_node *mem;
u64 reg[2];
- char name[sizeof("memory@") + STR_MAX_CHARS(reg[0])];
+ char *name;
u32 chip_id;
+ name = (char*)malloc(sizeof("memory@") + STR_MAX_CHARS(reg[0]));
+
prlog(PR_DEBUG, " Range: 0x%016llx..0x%016llx "
"on Chip 0x%x mattr: 0x%x\n",
(long long)arange->start, (long long)arange->end,
@@ -149,6 +151,8 @@ static bool add_address_range(struct dt_node *root,
dt_add_property_cells(mem, DT_PRIVATE "share-id",
be16_to_cpu(id->share_id));
+ free(name);
+
return true;
}