diff options
author | Gavin Shan <gwshan@linux.vnet.ibm.com> | 2016-09-21 21:53:36 +1000 |
---|---|---|
committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-09-22 14:47:25 +1000 |
commit | 171726631d014cd5e61170f06028474d900a827e (patch) | |
tree | db92266b21c38b3e2c1351c81bb5d081891d0098 /core/pci.c | |
parent | 366aee2e1d21721dadc69327896ec84756729a27 (diff) | |
download | skiboot-171726631d014cd5e61170f06028474d900a827e.zip skiboot-171726631d014cd5e61170f06028474d900a827e.tar.gz skiboot-171726631d014cd5e61170f06028474d900a827e.tar.bz2 |
core/pci: Fix the power-off timeout in pci_slot_power_off()
The timeout should be 1000ms instead of 1000 ticks while powering
off PCI slot in pci_slot_power_off(). Otherwise, it's likely to
hit timeout powering off the PCI slot as below skiboot logs reveal:
[47912590456,5] SkiBoot skiboot-5.3.6 starting...
:
[5399532365,7] PHB#0005:02:11.0 Bus 0f..ff scanning...
[5399540804,7] PHB#0005:02:11.0 No card in slot
[5399576870,5] PHB#0005:02:11.0 Timeout powering off slot
[5401431782,3] FIRENZE-PCI: Wrong state 00000000 on slot 8000000002880005
This replaces time_wait() with time_wait_ms() to resolve the issue.
Fixes: 358b4d654f100cfdfcba939cae012099a851b3bc
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'core/pci.c')
-rw-r--r-- | core/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -521,7 +521,7 @@ static void pci_slot_power_off(struct phb *phb, struct pci_device *pd) break; check_timers(false); - time_wait(10); + time_wait_ms(10); } while (--wait >= 0); pci_slot_set_state(slot, PCI_SLOT_STATE_NORMAL); |