aboutsummaryrefslogtreecommitdiff
path: root/core/pci-quirk.c
diff options
context:
space:
mode:
authorAndrew Jeffery <andrew@aj.id.au>2018-07-17 11:32:50 +0930
committerStewart Smith <stewart@linux.ibm.com>2018-07-17 01:13:14 -0500
commit467b00fdfd67add51bc54a62c7c70d14a9925717 (patch)
tree698c415f0a64bcec0d868622d6cbf590b2aa4e2f /core/pci-quirk.c
parent5b1bc2ffe791ae94361d86b2ae063ee543bf2df5 (diff)
downloadskiboot-467b00fdfd67add51bc54a62c7c70d14a9925717.zip
skiboot-467b00fdfd67add51bc54a62c7c70d14a9925717.tar.gz
skiboot-467b00fdfd67add51bc54a62c7c70d14a9925717.tar.bz2
core/pci-quirk: Remove broken comment in quirk_astbmc_vga()
The comment talks about one mechanism to handle the quirk whilst the code uses another. Avoid confusion by removing the comment. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'core/pci-quirk.c')
-rw-r--r--core/pci-quirk.c15
1 files changed, 0 insertions, 15 deletions
diff --git a/core/pci-quirk.c b/core/pci-quirk.c
index 1b60e92..9832407 100644
--- a/core/pci-quirk.c
+++ b/core/pci-quirk.c
@@ -25,21 +25,6 @@ static void quirk_astbmc_vga(struct phb *phb __unused,
struct dt_node *np = pd->dn;
uint32_t revision, mcr_configuration, mcr_scu_mpll, mcr_scu_strap;
- /*
- * These accesses will only work if the BMC address 0x1E6E2180 is set
- * to 0x7B, which is its default state on current systems. In future,
- * for security purposes it is proposed to configure this register to
- * disallow accesses from the host, and provide the properties that
- * the Linux ast VGA driver used through the device tree instead.
- * Here we set those properties so we can test how things would work
- * if the window into BMC memory was closed.
- *
- * If both the petitboot kernel and the host kernel have an ast driver
- * that reads properties from the device tree, setting 0x1E6E2180 to
- * 0x79 will disable the backdoor into BMC memory and the only way the
- * ast driver can operate is using the device tree properties.
- */
-
revision = ast_ahb_readl(SCU_REVISION_ID);
mcr_configuration = ast_ahb_readl(MCR_CONFIGURATION);
mcr_scu_mpll = ast_ahb_readl(MCR_SCU_MPLL);