aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOliver O'Halloran <oohall@gmail.com>2019-11-07 16:58:29 +1100
committerOliver O'Halloran <oohall@gmail.com>2019-11-07 17:46:33 +1100
commita0340a0995efae59d153eb8126474ef4b6f8320b (patch)
treed9a33a2dd914daeebd87d56d0ff26cf0382d0921
parentf9eb53d278cfded3d5da7789223ea0f64644717a (diff)
downloadskiboot-a0340a0995efae59d153eb8126474ef4b6f8320b.zip
skiboot-a0340a0995efae59d153eb8126474ef4b6f8320b.tar.gz
skiboot-a0340a0995efae59d153eb8126474ef4b6f8320b.tar.bz2
libstb/secvar: Ensure secvar_set_status() is called once
Remove the check to see if the "status" property already exists. This function is intended to only be called once so failing an assert is fine since it indicates a programming error. Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
-rw-r--r--libstb/secvar/secvar_devtree.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/libstb/secvar/secvar_devtree.c b/libstb/secvar/secvar_devtree.c
index fcff711..5489db7 100644
--- a/libstb/secvar/secvar_devtree.c
+++ b/libstb/secvar/secvar_devtree.c
@@ -47,11 +47,8 @@ void secvar_set_status(const char *status)
if (!secvar_node)
return; // Fail boot?
- if (dt_find_property(secvar_node, "status"))
- return;
-
+ /* This function should only be called once */
dt_add_property_string(secvar_node, "status", status);
- // Fail boot if not successful?
}