diff options
| author | Ted Kuo <ted.kuo@intel.com> | 2022-02-23 16:45:54 +0800 |
|---|---|---|
| committer | Ted Kuo <ted.kuo@intel.com> | 2022-02-23 16:45:54 +0800 |
| commit | 38165468b7f3f0198960d81bc9f53da567430778 (patch) | |
| tree | 7de427c325e55a17ecea71f102a2e3a201ec3e3b | |
| parent | aae857d0d05ac65152ed24992a4acd834a0a107c (diff) | |
| download | mipisyst-38165468b7f3f0198960d81bc9f53da567430778.zip mipisyst-38165468b7f3f0198960d81bc9f53da567430778.tar.gz mipisyst-38165468b7f3f0198960d81bc9f53da567430778.tar.bz2 | |
Change the static global variable - zero to local variable
Initializing header and handle structure with static global variable
results in an exception in X64 ARCH due to using SSE instruction
with unaligned address. Changed the static global variable - zero
to local variable to avoid the issue.
| -rw-r--r-- | library/src/mipi_syst_init.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/library/src/mipi_syst_init.c b/library/src/mipi_syst_init.c index 90ba5a5..9c213a6 100644 --- a/library/src/mipi_syst_init.c +++ b/library/src/mipi_syst_init.c @@ -36,6 +36,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * Norbert Schulz (Intel Corporation) - Initial API and implementation */ +#include <stdlib.h> #include "mipi_syst.h" #include "mipi_syst/message.h" @@ -44,11 +45,6 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ static struct mipi_syst_header syst_hdr = { 0 }; -static union mipi_syst_null_init { - struct mipi_syst_handle handle; - struct mipi_syst_header header; -} zero = { {0} }; /* for initializations */ - #if !defined(MIPI_SYST_PCFG_ENABLE_DEFAULT_SCATTER_WRITE) /** * null-device style default output function @@ -78,6 +74,7 @@ mipi_syst_init( mipi_syst_inithook_t pfinit, const void *init_param) { + struct mipi_syst_header zero_header = {0}; if (0 == header) { /* No user supplied global state storage, * use internal default state @@ -85,7 +82,7 @@ mipi_syst_init( header = &syst_hdr; } - *header = zero.header; + *header = zero_header; header->systh_version = MIPI_SYST_VERSION_CODE; #if MIPI_SYST_CONFORMANCE_LEVEL > 10 @@ -143,6 +140,7 @@ mipi_syst_init_handle( const struct mipi_syst_origin *origin, mipi_syst_u32 fromHeap) { + struct mipi_syst_handle zero_handle = {0}; if ((struct mipi_syst_handle*) 0 == svh) return svh; @@ -154,7 +152,7 @@ mipi_syst_init_handle( header = &syst_hdr; } - *svh = zero.handle; + *svh = zero_handle; svh->systh_header = header; svh->systh_flags.shf_alloc = fromHeap ? 1 : 0; @@ -183,6 +181,7 @@ mipi_syst_init_handle( */ MIPI_SYST_EXPORT void MIPI_SYST_CALLCONV mipi_syst_delete_handle(struct mipi_syst_handle* svh) { + struct mipi_syst_handle zero_handle = {0}; if ((struct mipi_syst_handle*) 0 != svh) { #if defined(MIPI_SYST_PCFG_ENABLE_PLATFORM_HANDLE_DATA) /* call platform handle release hook if defined @@ -198,7 +197,7 @@ MIPI_SYST_EXPORT void MIPI_SYST_CALLCONV mipi_syst_delete_handle(struct mipi_sys } else #endif { - *svh = zero.handle; + *svh = zero_handle; } } }
\ No newline at end of file |