summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c2
-rw-r--r--MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c2
-rw-r--r--MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c8
-rw-r--r--MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c12
-rw-r--r--MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c2
5 files changed, 14 insertions, 12 deletions
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
index cb892e3..55fe5c8 100644
--- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
+++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbDesc.c
@@ -359,7 +359,7 @@ UsbParseConfigDesc (
while (Len >= sizeof (EFI_USB_INTERFACE_DESCRIPTOR)) {
Setting = UsbParseInterfaceDesc (DescBuf, Len, &Consumed);
- if ((Setting == NULL)) {
+ if (Setting == NULL) {
DEBUG (( EFI_D_ERROR, "UsbParseConfigDesc: failed to parse interface setting\n"));
goto ON_ERROR;
diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index 13dff91..edec580 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -779,7 +779,7 @@ PeiDispatcher (
);
}
- if ((Status == EFI_SUCCESS)) {
+ if (Status == EFI_SUCCESS) {
//
// The PEIM has its dependencies satisfied, and its entry point
// has been found, so invoke it.
diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
index 92d677d..57704d8 100644
--- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
+++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c
@@ -1865,7 +1865,7 @@ ConSplitterTextInDeleteDevice (
//
for (Index = 0; Index < Private->CurrentNumberOfConsoles; Index++) {
if (Private->TextInList[Index] == TextIn) {
- for (Index = Index; Index < Private->CurrentNumberOfConsoles - 1; Index++) {
+ for (; Index < Private->CurrentNumberOfConsoles - 1; Index++) {
Private->TextInList[Index] = Private->TextInList[Index + 1];
}
@@ -1945,7 +1945,7 @@ ConSplitterTextInExDeleteDevice (
//
for (Index = 0; Index < Private->CurrentNumberOfExConsoles; Index++) {
if (Private->TextInExList[Index] == TextInEx) {
- for (Index = Index; Index < Private->CurrentNumberOfExConsoles - 1; Index++) {
+ for (; Index < Private->CurrentNumberOfExConsoles - 1; Index++) {
Private->TextInExList[Index] = Private->TextInExList[Index + 1];
}
@@ -2022,7 +2022,7 @@ ConSplitterSimplePointerDeleteDevice (
//
for (Index = 0; Index < Private->CurrentNumberOfPointers; Index++) {
if (Private->PointerList[Index] == SimplePointer) {
- for (Index = Index; Index < Private->CurrentNumberOfPointers - 1; Index++) {
+ for (; Index < Private->CurrentNumberOfPointers - 1; Index++) {
Private->PointerList[Index] = Private->PointerList[Index + 1];
}
@@ -2099,7 +2099,7 @@ ConSplitterAbsolutePointerDeleteDevice (
//
for (Index = 0; Index < Private->CurrentNumberOfAbsolutePointers; Index++) {
if (Private->AbsolutePointerList[Index] == AbsolutePointer) {
- for (Index = Index; Index < Private->CurrentNumberOfAbsolutePointers - 1; Index++) {
+ for (; Index < Private->CurrentNumberOfAbsolutePointers - 1; Index++) {
Private->AbsolutePointerList[Index] = Private->AbsolutePointerList[Index + 1];
}
diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
index 2d5f659..79e7093 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDhcp.c
@@ -235,7 +235,7 @@ IScsiDhcpSelectOffer (
break;
}
- if ((Index == OptionCount)) {
+ if (Index == OptionCount) {
Status = EFI_NOT_READY;
}
@@ -361,6 +361,7 @@ IScsiDoDhcp (
EFI_DHCP4_PACKET_OPTION *ParaList;
EFI_DHCP4_CONFIG_DATA Dhcp4ConfigData;
BOOLEAN MediaPresent;
+ UINT8 *Data;
Dhcp4Handle = NULL;
Dhcp4 = NULL;
@@ -410,10 +411,11 @@ IScsiDoDhcp (
//
ParaList->OpCode = DHCP4_TAG_PARA_LIST;
ParaList->Length = (UINT8) (ConfigData->NvData.TargetInfoFromDhcp ? 4 : 3);
- ParaList->Data[0] = DHCP4_TAG_NETMASK;
- ParaList->Data[1] = DHCP4_TAG_ROUTER;
- ParaList->Data[2] = DHCP4_TAG_DNS;
- ParaList->Data[3] = DHCP4_TAG_ROOT_PATH;
+ Data = &ParaList->Data[0];
+ Data[0] = DHCP4_TAG_NETMASK;
+ Data[1] = DHCP4_TAG_ROUTER;
+ Data[2] = DHCP4_TAG_DNS;
+ Data[3] = DHCP4_TAG_ROOT_PATH;
ZeroMem (&Dhcp4ConfigData, sizeof (EFI_DHCP4_CONFIG_DATA));
Dhcp4ConfigData.OptionCount = 1;
diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
index 0b17c7e..dea7f7c 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiExtScsiPassThru.c
@@ -183,7 +183,7 @@ IScsiExtScsiPassThruBuildDevicePath (
EFI_DEV_PATH *Node;
UINTN DevPathNodeLen;
- if ((DevicePath == NULL)) {
+ if (DevicePath == NULL) {
return EFI_INVALID_PARAMETER;
}