UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info.

Because MSR has scope attribute, driver has no needs to set
MSR for all APs if MSR scope is core or package type. This patch
updates code to base on the MSR scope value to add MSR to the register
table.

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

12 files changed, 190 insertions, 0 deletions

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c
index 4711635..1beaebe 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/C1e.c
@@ -67,6 +67,14 @@ C1eInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of C1EEnable bit in the MSR_NEHALEM_POWER_CTL is Package, only program

+  // MSR_FEATURE_CONFIG for thread 0 core 0 in each package.

+  //

+  if ((CpuInfo->ProcessorInfo.Location.Thread != 0) || (CpuInfo->ProcessorInfo.Location.Core != 0)) {

+  return RETURN_SUCCESS;

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Eist.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Eist.c
index 2038171..f30117d 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Eist.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Eist.c
@@ -69,6 +69,18 @@ EistInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of the MSR_IA32_MISC_ENABLE is core for below processor type, only program

+  // MSR_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  if (IS_ATOM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE2_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ExecuteDisable.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ExecuteDisable.c
index 921656a..ff06cb9 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ExecuteDisable.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ExecuteDisable.c
@@ -79,6 +79,16 @@ ExecuteDisableInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of the MSR_IA32_EFER is core for below processor type, only program

+  // MSR_IA32_EFER for thread 0 in each core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/FastStrings.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/FastStrings.c
index 029bcf8..2682093 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/FastStrings.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/FastStrings.c
@@ -40,6 +40,18 @@ FastStringsInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of FastStrings bit in the MSR_IA32_MISC_ENABLE is core for below processor type, only program

+  // MSR_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c
index d28c4ec..8c1eb5e 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c
@@ -96,6 +96,19 @@ VmxInitialize (
 {

   MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;

 

+  //

+  // The scope of EnableVmxOutsideSmx bit in the MSR_IA32_FEATURE_CONTROL is core for

+  // below processor type, only program MSR_IA32_FEATURE_CONTROL for thread 0 in each

+  // core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PLUS_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   ASSERT (ConfigData != NULL);

   MsrRegister = (MSR_IA32_FEATURE_CONTROL_REGISTER *) ConfigData;

   if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {

@@ -171,6 +184,19 @@ LockFeatureControlRegisterInitialize (
 {

   MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;

 

+  //

+  // The scope of Lock bit in the MSR_IA32_FEATURE_CONTROL is core for

+  // below processor type, only program MSR_IA32_FEATURE_CONTROL for thread 0 in each

+  // core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PLUS_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   ASSERT (ConfigData != NULL);

   MsrRegister = (MSR_IA32_FEATURE_CONTROL_REGISTER *) ConfigData;

   if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {

@@ -248,6 +274,18 @@ SmxInitialize (
   MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;

   RETURN_STATUS                        Status;

 

+  //

+  // The scope of Lock bit in the MSR_IA32_FEATURE_CONTROL is core for

+  // below processor type, only program MSR_IA32_FEATURE_CONTROL for thread 0 in each

+  // core.

+  //

+  if (IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PLUS_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   Status = RETURN_SUCCESS;

 

   if (State && (!IsCpuFeatureInSetting (CPU_FEATURE_VMX))) {

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
index 3d41efe..eab1fb5 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
@@ -70,6 +70,20 @@ LimitCpuidMaxvalInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of LimitCpuidMaxval bit in the MSR_IA32_MISC_ENABLE is core for below

+  // processor type, only program MSR_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  if (IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||


+      IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE2_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
index c4eca06..f8bee53 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
@@ -140,6 +140,32 @@ McaInitialize (
   MSR_IA32_MCG_CAP_REGISTER  McgCap;

   UINT32                     BankIndex;

 

+  //

+  // The scope of MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS is core for below processor type, only program

+  // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS for thread 0 in each core.

+  //

+  if (IS_ATOM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_SANDY_BRIDGE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_SKYLAKE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_XEON_PHI_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

+  //

+  // The scope of MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS is package for below processor type, only program

+  // MSR_IA32_MC*_CTL/MSR_IA32_MC*_STATUS for thread 0 core 0 in each package.

+  //

+  if (IS_NEHALEM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if ((CpuInfo->ProcessorInfo.Location.Thread != 0) || (CpuInfo->ProcessorInfo.Location.Core != 0)) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   if (State) {

     McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);

     for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) {

@@ -301,6 +327,18 @@ LmceInitialize (
 {

   MSR_IA32_FEATURE_CONTROL_REGISTER    *MsrRegister;

 

+  //

+  // The scope of FastStrings bit in the MSR_IA32_MISC_ENABLE is core for below processor type, only program 

+  // MSR_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   ASSERT (ConfigData != NULL);

   MsrRegister = (MSR_IA32_FEATURE_CONTROL_REGISTER *) ConfigData;

   if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MonitorMwait.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MonitorMwait.c
index 1d43bd1..530748b 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MonitorMwait.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MonitorMwait.c
@@ -67,6 +67,21 @@ MonitorMwaitInitialize (
   IN BOOLEAN                           State

   )

 {

+  //

+  // The scope of the MSR_IA32_MISC_ENABLE is core for below processor type, only program

+  // MSR_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  if (IS_CORE2_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_ATOM_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_PENTIUM_4_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_CORE_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/PendingBreak.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/PendingBreak.c
index 8cafba4..2e0d2bd 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/PendingBreak.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/PendingBreak.c
@@ -75,6 +75,17 @@ PendingBreakInitialize (
   )

 {

   //

+  // The scope of the MSR_ATOM_IA32_MISC_ENABLE is core for below processor type, only program

+  // MSR_ATOM_IA32_MISC_ENABLE for thread 0 in each core.

+  //

+  // Support function has check the processer type for this feature, no need to check again

+  // here.

+  //

+  if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+    return RETURN_SUCCESS;

+  }

+

+  //

   // ATOM, CORE2, CORE, PENTIUM_4 and IS_PENTIUM_M_PROCESSOR have the same MSR index,

   // Simply use MSR_ATOM_IA32_MISC_ENABLE here

   //

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c
index 721470c..d6219f4 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/Ppin.c
@@ -101,6 +101,17 @@ PpinInitialize (
     return MsrPpinCtrl.Bits.Enable_PPIN == State ? RETURN_SUCCESS : RETURN_DEVICE_ERROR;

   }

 

+  //

+  // Support function already check the processor which support PPIN feature, so this function not need

+  // to check the processor again.

+  //

+  // The scope of the MSR_IVY_BRIDGE_PPIN_CTL is package level, only program MSR_IVY_BRIDGE_PPIN_CTL for

+  // thread 0 core 0 in each package.

+  //

+  if ((CpuInfo->ProcessorInfo.Location.Thread != 0) || (CpuInfo->ProcessorInfo.Location.Core != 0)) {

+    return RETURN_SUCCESS;

+  }

+

   CPU_REGISTER_TABLE_WRITE_FIELD (

     ProcessorNumber,

     Msr,

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c
index 98490c6..cf34ad4 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c
@@ -191,6 +191,17 @@ ProcTraceInitialize (
   MSR_IA32_RTIT_OUTPUT_MASK_PTRS_REGISTER  OutputMaskPtrsReg;

   RTIT_TOPA_TABLE_ENTRY                *TopaEntryPtr;

 

+  //

+  // The scope of the MSR_IA32_RTIT_* is core for below processor type, only program

+  // MSR_IA32_RTIT_* for thread 0 in each core.

+  //

+  if (IS_GOLDMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel) ||

+      IS_GOLDMONT_PLUS_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   ProcTraceData = (PROC_TRACE_DATA *) ConfigData;

   ASSERT (ProcTraceData != NULL);

 

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/X2Apic.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/X2Apic.c
index b4a453c..342b45f 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/X2Apic.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/X2Apic.c
@@ -102,6 +102,16 @@ X2ApicInitialize (
 {

   BOOLEAN                            *X2ApicEnabled;

 

+  //

+  // The scope of the MSR_IA32_APIC_BASE is core for below processor type, only program

+  // MSR_IA32_APIC_BASE for thread 0 in each core.

+  //

+  if (IS_SILVERMONT_PROCESSOR (CpuInfo->DisplayFamily, CpuInfo->DisplayModel)) {

+    if (CpuInfo->ProcessorInfo.Location.Thread != 0) {

+      return RETURN_SUCCESS;

+    }

+  }

+

   ASSERT (ConfigData != NULL);

   X2ApicEnabled = (BOOLEAN *) ConfigData;

   if (X2ApicEnabled[ProcessorNumber]) {