diff options
author | Eric Dong <eric.dong@intel.com> | 2017-12-21 19:46:51 +0800 |
---|---|---|
committer | Eric Dong <eric.dong@intel.com> | 2017-12-27 15:31:33 +0800 |
commit | 8766d3a3e8150c48d8f2cf5764d48b792de74ee1 (patch) | |
tree | be0ae4ccb8be70aef4dc464fa5b0a9a5c0aaeeed /UefiCpuPkg/Library | |
parent | 726c501c2c9a1ef103fab7846e2d1a34506715d8 (diff) | |
download | edk2-8766d3a3e8150c48d8f2cf5764d48b792de74ee1.zip edk2-8766d3a3e8150c48d8f2cf5764d48b792de74ee1.tar.gz edk2-8766d3a3e8150c48d8f2cf5764d48b792de74ee1.tar.bz2 |
Revert "UefiCpuPkg: Check invalid RegisterCpuFeature parameter"
This reverts commit 5c59537c1092a1372913274636a8d766fdd97e61.
Current code already has function IsCpuFeatureSupported to do
the feature validation, not need this check logic anymore.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Diffstat (limited to 'UefiCpuPkg/Library')
-rw-r--r-- | UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c | 29 |
1 files changed, 0 insertions, 29 deletions
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c index 6ec26e1..dd6a82b 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c @@ -81,34 +81,6 @@ DumpCpuFeature ( }
/**
- Determines if the CPU feature is valid.
-
- @param[in] Feature Pointer to CPU feature
-
- @retval TRUE The CPU feature is valid.
- @retval FALSE The CPU feature is invalid.
-**/
-BOOLEAN
-RegisterCpuFeatureLibIsFeatureValid (
- IN UINT32 Feature
- )
-{
- UINT32 Data;
-
- Data = Feature;
- Data &= ~(CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER | CPU_FEATURE_BEFORE_ALL | CPU_FEATURE_AFTER_ALL);
- //
- // Currently, CPU_FEATURE_PROC_TRACE is the MAX feature we support.
- // If you define a feature bigger than it, please replace it at below.
- //
- if (Data > CPU_FEATURE_PROC_TRACE) {
- DEBUG ((DEBUG_ERROR, "Invalid CPU feature: 0x%x ", Feature));
- return FALSE;
- }
- return TRUE;
-}
-
-/**
Determines if the feature bit mask is in dependent CPU feature bit mask buffer.
@param[in] FeatureMask Pointer to CPU feature bit mask
@@ -472,7 +444,6 @@ RegisterCpuFeature ( VA_START (Marker, InitializeFunc);
Feature = VA_ARG (Marker, UINT32);
- ASSERT (RegisterCpuFeatureLibIsFeatureValid(Feature));
while (Feature != CPU_FEATURE_END) {
ASSERT ((Feature & (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER))
!= (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER));
|