summaryrefslogtreecommitdiff
path: root/ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2018-07-18 19:38:40 +0200
committerLaszlo Ersek <lersek@redhat.com>2018-08-16 20:02:51 +0200
commit9becf2f0759eab29afcb088ee5c49f522d1d6619 (patch)
treefc66c154f21e91199fb67f6e72d28240be4111f8 /ShellPkg/Library/UefiShellLib/UefiShellLib.inf
parent15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097 (diff)
downloadedk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.zip
edk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.tar.gz
edk2-9becf2f0759eab29afcb088ee5c49f522d1d6619.tar.bz2
ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib API
Replace the "old shell method" implementation in ShellOpenFileByDevicePath() with EfiOpenFileByDevicePath() from UefiLib, correcting the following issues: - code duplication between this module and other modules, - local variable name "EfiSimpleFileSystemProtocol" starting with "Efi" prefix, - bogus "FileHandle = NULL" assignments, - leaking "Handle1" when the device path type/subtype check or the realignment-motivated AllocateCopyPool() fails in the loop. Cc: Jaben Carsey <jaben.carsey@intel.com> Cc: Ruiyu Ni <ruiyu.ni@intel.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008 Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Diffstat (limited to 'ShellPkg/Library/UefiShellLib/UefiShellLib.inf')
-rw-r--r--ShellPkg/Library/UefiShellLib/UefiShellLib.inf1
1 files changed, 0 insertions, 1 deletions
diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.inf b/ShellPkg/Library/UefiShellLib/UefiShellLib.inf
index 38d9a4b..aacddbb 100644
--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.inf
@@ -51,7 +51,6 @@
SortLib
[Protocols]
- gEfiSimpleFileSystemProtocolGuid ## SOMETIMES_CONSUMES
gEfiUnicodeCollation2ProtocolGuid ## CONSUMES
# shell 2.0