diff options
author | Laszlo Ersek <lersek@redhat.com> | 2018-03-13 15:55:12 +0100 |
---|---|---|
committer | Laszlo Ersek <lersek@redhat.com> | 2018-03-14 11:24:22 +0100 |
commit | 90f09188462cc9f2166fe5690639dea5412f2ef4 (patch) | |
tree | 30c0e40839a4c128ddc8aba2465ef7e27c160cd9 /OvmfPkg | |
parent | 5851b8253a31db5a5e62847cf0c70f5629542de0 (diff) | |
download | edk2-90f09188462cc9f2166fe5690639dea5412f2ef4.zip edk2-90f09188462cc9f2166fe5690639dea5412f2ef4.tar.gz edk2-90f09188462cc9f2166fe5690639dea5412f2ef4.tar.bz2 |
OvmfPkg/QemuBootOrderLib: clean up translation of virtio-net over MMIO
The "/MAC(" suffix of the translated UEFI devpath prefix is unnecessary
for matching, because the virtio-mmio base address in VenHwString is
unique anyway. Furthermore, the partial string "MAC(" cannot be processed
by ConvertTextToDevicePath(), which will become relevant later in this
series. Remove "/MAC(".
While at it, remove a bogus comment on PCI.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: Xiang Zheng <xiang.zheng@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> # ArmVirtQemu
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Xiang Zheng <xiang.zheng@linaro.org>
Diffstat (limited to 'OvmfPkg')
-rw-r--r-- | OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c b/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c index b699970..a4213cf 100644 --- a/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c +++ b/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c @@ -1217,14 +1217,14 @@ TranslateMmioOfwNodes ( // | fixed
// base address of virtio-mmio register block
//
- // UEFI device path prefix (dependent on presence of nonzero PCI function):
+ // UEFI device path prefix:
//
- // <VenHwString>/MAC(
+ // <VenHwString>
//
Written = UnicodeSPrintAsciiFormat (
Translated,
*TranslatedSize * sizeof (*Translated), // BufferSize in bytes
- "%s/MAC(",
+ "%s",
VenHwString
);
} else {
|