diff options
author | Laszlo Ersek <lersek@redhat.com> | 2018-03-23 22:36:41 +0100 |
---|---|---|
committer | Laszlo Ersek <lersek@redhat.com> | 2018-03-26 16:59:47 +0200 |
commit | e1fb441624cdb50bdf7b45afdb8071534e2cdbc3 (patch) | |
tree | 3401640d75d71fb20342e502d82cda736b3af33b /OvmfPkg/QemuVideoDxe/Gop.c | |
parent | d9885abf80c3bcabea4aafe6c36a79e17c04ea66 (diff) | |
download | edk2-e1fb441624cdb50bdf7b45afdb8071534e2cdbc3.zip edk2-e1fb441624cdb50bdf7b45afdb8071534e2cdbc3.tar.gz edk2-e1fb441624cdb50bdf7b45afdb8071534e2cdbc3.tar.bz2 |
OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully
According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed
to catch an invalid BltOperation, and report it with
EFI_INVALID_PARAMETER.
Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this
from working in NOOPT and DEBUG builds.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Rocky <xingrong.ni@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Reported-by: Rocky <xingrong.ni@intel.com>
Analyzed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Diffstat (limited to 'OvmfPkg/QemuVideoDxe/Gop.c')
-rw-r--r-- | OvmfPkg/QemuVideoDxe/Gop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c index b479d24..d51efc2 100644 --- a/OvmfPkg/QemuVideoDxe/Gop.c +++ b/OvmfPkg/QemuVideoDxe/Gop.c @@ -366,7 +366,7 @@ Returns: default:
Status = EFI_INVALID_PARAMETER;
- ASSERT (FALSE);
+ break;
}
gBS->RestoreTPL (OriginalTPL);
|