diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2020-03-12 23:35:54 +0100 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2020-03-13 17:25:00 +0000 |
| commit | 912718d8c7c783c310a34f6a2dd816c359d9624a (patch) | |
| tree | 0174c276409c13b275a1dedd8de709f8c60bbf48 /OvmfPkg/PlatformPei | |
| parent | d42fdd6f8384bb4681d93e4a25d8f57db1e63adb (diff) | |
| download | edk2-912718d8c7c783c310a34f6a2dd816c359d9624a.zip edk2-912718d8c7c783c310a34f6a2dd816c359d9624a.tar.gz edk2-912718d8c7c783c310a34f6a2dd816c359d9624a.tar.bz2 | |
OvmfPkg/PlatformPei: explain EFI_MEMORY_TYPE_INFORMATION page counts
Add a code comment that explains the nature of the NumberOfPages field
values. Including this kind of historical information was suggested by
Leif in <https://edk2.groups.io/g/devel/message/55797> (alternative link:
<http://mid.mail-archive.com/20200312104006.GB23627@bivouac.eciton.net>).
Right now, the most recent commit updating the page counts has been commit
991d95636264 ("[...] Update default memory type information to reduce EFI
Memory Map fragmentation.", 2010-07-16).
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20200312223555.29267-2-lersek@redhat.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Diffstat (limited to 'OvmfPkg/PlatformPei')
| -rw-r--r-- | OvmfPkg/PlatformPei/MemTypeInfo.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/OvmfPkg/PlatformPei/MemTypeInfo.c b/OvmfPkg/PlatformPei/MemTypeInfo.c index c709236..863c6f3 100644 --- a/OvmfPkg/PlatformPei/MemTypeInfo.c +++ b/OvmfPkg/PlatformPei/MemTypeInfo.c @@ -19,6 +19,12 @@ #include "Platform.h"
+//
+// The NumberOfPages values below are ad-hoc. They are updated sporadically at
+// best (please refer to git-blame for past updates). The values capture a set
+// of BIN hints that made sense at a particular time, for some (now likely
+// unknown) workloads / boot paths.
+//
STATIC EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = {
{ EfiACPIMemoryNVS, 0x004 },
{ EfiACPIReclaimMemory, 0x008 },
|