summaryrefslogtreecommitdiff
path: root/MdeModulePkg
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2013-12-04 08:19:02 +0000
committerlzeng14 <lzeng14@6f19259b-4bc3-4df7-8a09-765794883524>2013-12-04 08:19:02 +0000
commit060853f7aa578af06a86f20216b1df71a82531ab (patch)
treefcbcb07a071eb1c6e4b719fba699ea67e6a2deb4 /MdeModulePkg
parent5ab7f883fb46f23114951d644d457eb854b8e977 (diff)
downloadedk2-060853f7aa578af06a86f20216b1df71a82531ab.zip
edk2-060853f7aa578af06a86f20216b1df71a82531ab.tar.gz
edk2-060853f7aa578af06a86f20216b1df71a82531ab.tar.bz2
MdeModulePkg: SmmLockBox: remove wrong DepEx
The SmmLockBox driver in "MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf" currently specifies a DepEx on EFI_SMM_SW_DISPATCH2_PROTOCOL. However, the driver doesn't use this protocol at all, either directly or indirectly. It calls SmiHandlerRegister() [MdeModulePkg/Core/PiSmmCore/Smi.c] to register SmmLockBoxHandler() (which serves LockBox requests). In turn, the SMM Core function SmiHandlerRegister() is also implemented without EFI_SMM_SW_DISPATCH2_PROTOCOL. The DepEx has been present since the initial commit of the SmmLockBox driver (SVN r12029); it is probably superfluous. Let's remove it. (Alternatively, we could extend OvmfPkg/EmuSmmDxe to fake this protocol, and return EFI_UNSUPPORTED when any member is called.) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14930 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'MdeModulePkg')
-rw-r--r--MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf3
1 files changed, 1 insertions, 2 deletions
diff --git a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
index 529ca77..1804e8a 100644
--- a/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
+++ b/MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf
@@ -60,5 +60,4 @@
gEfiLockBoxProtocolGuid ## PRODUCED
[Depex]
- gEfiSmmSwDispatch2ProtocolGuid
-
+ TRUE