diff options
author | Hao Wu <hao.a.wu@intel.com> | 2018-10-10 21:00:20 +0800 |
---|---|---|
committer | Hao Wu <hao.a.wu@intel.com> | 2018-10-18 09:12:51 +0800 |
commit | 11941d3b1bfab594ff108ddbfed61bc31e8eb674 (patch) | |
tree | ba08b12f72dc07a80e81c0d766cf435285baed69 /MdeModulePkg/Universal/Disk | |
parent | f355dd34049c88167768e4a8acf85934aaae2dd2 (diff) | |
download | edk2-11941d3b1bfab594ff108ddbfed61bc31e8eb674.zip edk2-11941d3b1bfab594ff108ddbfed61bc31e8eb674.tar.gz edk2-11941d3b1bfab594ff108ddbfed61bc31e8eb674.tar.bz2 |
MdeModulePkg/UdfDxe: Handle dead codes in File.c
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1249
We found potential dead codes within File.c during the code coverage test.
After manual review, we think the below ones are positive reports:
A. In function UdfRead():
else if (IS_FID_DELETED_FILE (Parent->FileIdentifierDesc)) {
Status = EFI_DEVICE_ERROR;
}
A File Identifier Descriptor will be get from the UDF media only by
function ReadDirectoryEntry(). And within this function, all the File
Identifier Descriptor with 'DELETED_FILE' characteristics will be skipped
and will not be returned. Hence, the above codes in function UdfRead()
will never be hit.
This commit will add "ASSERT (FALSE);" before the above line to indicate
this.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Diffstat (limited to 'MdeModulePkg/Universal/Disk')
-rw-r--r-- | MdeModulePkg/Universal/Disk/UdfDxe/File.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/MdeModulePkg/Universal/Disk/UdfDxe/File.c b/MdeModulePkg/Universal/Disk/UdfDxe/File.c index 0730e6a..eb7d796 100644 --- a/MdeModulePkg/Universal/Disk/UdfDxe/File.c +++ b/MdeModulePkg/Universal/Disk/UdfDxe/File.c @@ -500,6 +500,10 @@ UdfRead ( PrivFileData->FilePosition++;
Status = EFI_SUCCESS;
} else if (IS_FID_DELETED_FILE (Parent->FileIdentifierDesc)) {
+ //
+ // Code should never reach here.
+ //
+ ASSERT (FALSE);
Status = EFI_DEVICE_ERROR;
}
|