diff options
| author | qhuang8 <qhuang8@6f19259b-4bc3-4df7-8a09-765794883524> | 2008-09-17 13:29:44 +0000 |
|---|---|---|
| committer | qhuang8 <qhuang8@6f19259b-4bc3-4df7-8a09-765794883524> | 2008-09-17 13:29:44 +0000 |
| commit | 57b4ecb94bceac2484dd9367b2ad111b05e17d97 (patch) | |
| tree | 41f8c66a71360a0cc33ee005aec6f771954bafc7 /EdkCompatibilityPkg | |
| parent | d45fd260267ee70c093519eb1e4a1ef285549e85 (diff) | |
| download | edk2-57b4ecb94bceac2484dd9367b2ad111b05e17d97.zip edk2-57b4ecb94bceac2484dd9367b2ad111b05e17d97.tar.gz edk2-57b4ecb94bceac2484dd9367b2ad111b05e17d97.tar.bz2 | |
Fix several code review minor comments:
1. Line 79:Use the pre-initialized global variable mPoolHeadList = INITIALIZE_LIST_HEAD_VARIABLE (mPoolHeadList) to remove the statement in line 102
2. Line 337: The debug print statement: “Addr = %x” should change to “Addr = %p” since the expected Buffer is VOID *; How about “(len %x) %,d” ? The Size & Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx
3.Line 413, 418, 425, 477: Use “Buffer != NULL” instead of “NULL != Buffer”
4. Line 451: The debug print statement: “FreePool = %x” should change to FreePool = %p” since Head->Data is pointer; How about “(len %x) %,d” ? The Head->Size& Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5916 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'EdkCompatibilityPkg')
0 files changed, 0 insertions, 0 deletions